Skip to content

Enhance ConversationStatusIndicators with upload status indication#217

Merged
ussaama merged 1 commit intomainfrom
conversation-red-dot-status
Jul 15, 2025
Merged

Enhance ConversationStatusIndicators with upload status indication#217
ussaama merged 1 commit intomainfrom
conversation-red-dot-status

Conversation

@ussaama
Copy link
Copy Markdown
Contributor

@ussaama ussaama commented Jul 15, 2025

  • Added a visual indicator for ongoing uploads when the conversation is not finished, improving user awareness of processing status.
  • Refactored tooltip label formatting for better readability.
  • Cleaned up conditional rendering for error handling in conversation status display.

Summary by CodeRabbit

  • New Features

    • Added a pulsing red dot indicator for conversations from the portal that are not finished.
  • Style

    • Improved formatting of tooltip labels and cleaned up whitespace in badge display.

- Added a visual indicator for ongoing uploads when the conversation is not finished, improving user awareness of processing status.
- Refactored tooltip label formatting for better readability.
- Cleaned up conditional rendering for error handling in conversation status display.
@ussaama ussaama requested a review from spashii July 15, 2025 13:59
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A pulsing red dot indicator was introduced in the ConversationStatusIndicators component to visually flag portal-origin conversations that are not finished. Minor formatting tweaks were applied to tooltip label strings and whitespace in JSX rendering. No exported API or signature changes occurred.

Changes

File(s) Change Summary
echo/frontend/src/components/conversation/ConversationAccordion.tsx Added pulsing red dot for unfinished portal conversations, reformatted tooltip label, cleaned whitespace

Suggested reviewers

  • spashii

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a72593 and 06a09c9.

📒 Files selected for processing (1)
  • echo/frontend/src/components/conversation/ConversationAccordion.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ussaama ussaama added this pull request to the merge queue Jul 15, 2025
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upload Indicator Shows Incorrectly

The visual indicator intended for ongoing uploads is incorrectly displayed for non-upload (portal) conversations that are not finished. The condition !isUpload && conversation.is_finished === false should be isUpload && conversation.is_finished === false to correctly show the indicator for ongoing uploads.

echo/frontend/src/components/conversation/ConversationAccordion.tsx#L389-L395

{
// if from portal and not finished
!isUpload && conversation.is_finished === false && (
<div className="h-2 w-2 animate-pulse rounded-full bg-red-500" />
)
}

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Merged via the queue into main with commit 23b2d0c Jul 15, 2025
11 of 12 checks passed
@coderabbitai coderabbitai bot requested a review from spashii July 15, 2025 14:02
@ussaama ussaama deleted the conversation-red-dot-status branch July 15, 2025 14:07
spashii pushed a commit that referenced this pull request Nov 18, 2025
)

- Added a visual indicator for ongoing uploads when the conversation is not finished, improving user awareness of processing status.
- Refactored tooltip label formatting for better readability.
- Cleaned up conditional rendering for error handling in conversation status display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants