Skip to content

fix view (adds description) #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spashii merged 1 commit into from
Jul 18, 2025
Merged

fix view (adds description) #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion echo/directus/sync/snapshot/fields/view/aspects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"readonly": false,
"required": false,
"sort": 7,
"sort": 8,
"special": [
"o2m"
],
Expand Down
43 changes: 43 additions & 0 deletions echo/directus/sync/snapshot/fields/view/description.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
{
"collection": "view",
"field": "description",
"type": "text",
"meta": {
"collection": "view",
"conditions": null,
"display": null,
"display_options": null,
"field": "description",
"group": null,
"hidden": false,
"interface": "input-multiline",
"note": null,
"options": null,
"readonly": false,
"required": false,
"sort": 6,
"special": null,
"translations": null,
"validation": null,
"validation_message": null,
"width": "full"
},
"schema": {
"name": "description",
"table": "view",
"data_type": "text",
"default_value": null,
"max_length": null,
"numeric_precision": null,
"numeric_scale": null,
"is_nullable": true,
"is_unique": false,
"is_indexed": false,
"is_primary_key": false,
"is_generated": false,
"generation_expression": null,
"has_auto_increment": false,
"foreign_key_table": null,
"foreign_key_column": null
}
}
43 changes: 43 additions & 0 deletions echo/directus/sync/snapshot/fields/view/language.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
{
"collection": "view",
"field": "language",
"type": "string",
"meta": {
"collection": "view",
"conditions": null,
"display": null,
"display_options": null,
"field": "language",
"group": null,
"hidden": false,
"interface": "input",
"note": null,
"options": null,
"readonly": false,
"required": false,
"sort": 11,
"special": null,
"translations": null,
"validation": null,
"validation_message": null,
"width": "full"
},
"schema": {
"name": "language",
"table": "view",
"data_type": "character varying",
"default_value": null,
"max_length": 255,
"numeric_precision": null,
"numeric_scale": null,
"is_nullable": true,
"is_unique": false,
"is_indexed": false,
"is_primary_key": false,
"is_generated": false,
"generation_expression": null,
"has_auto_increment": false,
"foreign_key_table": null,
"foreign_key_column": null
}
}
2 changes: 1 addition & 1 deletion echo/directus/sync/snapshot/fields/view/summary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"options": null,
"readonly": false,
"required": false,
"sort": 6,
"sort": 7,
"special": null,
"translations": null,
"validation": null,
Expand Down
2 changes: 1 addition & 1 deletion echo/directus/sync/snapshot/fields/view/user_input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"options": null,
"readonly": false,
"required": false,
"sort": 8,
"sort": 9,
"special": null,
"translations": null,
"validation": null,
Expand Down
2 changes: 1 addition & 1 deletion echo/directus/sync/snapshot/fields/view/user_input_description.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"options": null,
"readonly": false,
"required": false,
"sort": 9,
"sort": 10,
"special": null,
"translations": null,
"validation": null,
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/components/quote/Quote.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const Quote = ({
{conversationId && (
<Group mt="md" pt="sm" className="border-t border-gray-200 dark:border-gray-700">
<I18nLink
to={`/projects/${projectId}/conversation/${conversationId}/analysis`}
to={`/projects/${projectId}/conversation/${conversationId}/transcript`}
>
<Pill
size="sm"
Expand Down
10 changes: 4 additions & 6 deletions echo/frontend/src/components/view/View.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,22 @@ import { Trans } from "@lingui/react/macro";
import { Icons } from "@/icons";
import {
ActionIcon,
Button,
CopyButton,
Group,
Paper,
Pill,
Spoiler,
Stack,
Text,
} from "@mantine/core";
import { IconArrowsDiagonal, IconCopy } from "@tabler/icons-react";
import { IconArrowsDiagonal } from "@tabler/icons-react";
import { AspectCard } from "../aspect/AspectCard";
import { Link, useParams } from "react-router-dom";
import { useParams } from "react-router-dom";
import { Markdown } from "../common/Markdown";
import { I18nLink } from "../common/i18nLink";
import { useCopyView } from "../../hooks/useCopyView";
import { CopyIconButton } from "../common/CopyIconButton";

export const ViewCard = ({ data }: { data: TView }) => {
export const ViewCard = ({ data }: { data: View }) => {
return (
<Paper bg="white" p="md">
<Stack gap="sm">
Expand Down Expand Up @@ -85,7 +83,7 @@ export const ViewExpandedCard = ({ data }: { data: View }) => {
</Pill>
</Group>
<Spoiler maxHeight={120} showLabel="Show more" hideLabel="Show less">
<Markdown content={data.summary ?? ""} />
<Markdown content={data.description ?? ""} />
</Spoiler>

<div className="flex w-full snap-x overflow-x-auto pb-2">
Expand Down
1 change: 1 addition & 0 deletions echo/frontend/src/lib/typesDirectus.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,7 @@ type View = {
updated_at?: string | null;
user_input?: string | null;
user_input_description?: string | null;
description?: string | null;
};

type CustomDirectusTypes = {
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/routes/project/library/ProjectLibraryAspect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const ProjectLibraryAspect = () => {
<>
{aspect?.aspect_segment?.length && aspect?.aspect_segment?.length > 0 && (
<Title order={2}>
<Trans>Segments</Trans>
<Trans>Insights</Trans>
</Title>
Comment on lines 83 to 85
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

❓ Verification inconclusive

Copy tweak ✅ – make sure i18n catalog is updated.

Renaming the H2 from “Segments” → “Insights” is purely presentational. Run lingui extract (or your i18n pipeline) so translators pick up the new string; otherwise the runtime will fall back to English.

LGTM – update i18n catalog for new “Insights” heading

  • File: echo/frontend/src/routes/project/library/ProjectLibraryAspect.tsx (lines 83–85)
    <Trans>Insights</Trans>

Run lingui extract (or your i18n pipeline) so translators pick up the new string and avoid falling back to English at runtime.

🤖 Prompt for AI Agents 
In echo/frontend/src/routes/project/library/ProjectLibraryAspect.tsx around
lines 83 to 85, the new translatable string "Insights" has been added using the
<Trans> component. To ensure this string is included in the i18n catalog and
available for translation, run the command `lingui extract` or your project's
equivalent i18n extraction pipeline. This will update the translation files so
translators can provide localized versions and prevent fallback to English at
runtime.

)}
{aspect?.aspect_segment?.map((segment: AspectSegment) => (
Expand Down