Skip to content

ECHO-320 Refactor Project Chat to always display Chat Templates#235

Merged
ussaama merged 1 commit intomainfrom
chat-template-update
Jul 23, 2025
Merged

ECHO-320 Refactor Project Chat to always display Chat Templates#235
ussaama merged 1 commit intomainfrom
chat-template-update

Conversation

@ussaama
Copy link
Copy Markdown
Contributor

@ussaama ussaama commented Jul 22, 2025

Summary by CodeRabbit

  • Refactor
    • Simplified the display logic so that the chat templates menu in the project chat footer is now always visible.
    • Adjusted footer spacing for improved layout.

@linear
Copy link
Copy Markdown

linear bot commented Jul 22, 2025

@ussaama ussaama requested a review from spashii July 22, 2025 13:03
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 22, 2025

Walkthrough

The conditional logic for displaying the <ChatTemplatesMenu> in the ProjectChatRoute footer was removed, making the menu always visible. The padding of the surrounding <Stack> was slightly adjusted. No other component logic or exported entity was changed.

Changes

File(s) Change Summary
echo/frontend/src/routes/project/chat/ProjectChatRoute.tsx Simplified footer rendering: <ChatTemplatesMenu> now always rendered; adjusted padding.

Estimated code review effort

1 (~2 minutes)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4139137 and 152e543.

📒 Files selected for processing (1)
  • echo/frontend/src/routes/project/chat/ProjectChatRoute.tsx (1 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: ussaama
PR: Dembrane/echo#224
File: echo/frontend/src/components/report/CreateReportForm.tsx:97-155
Timestamp: 2025-07-17T15:57:51.295Z
Learning: In echo/frontend/src/components/report/CreateReportForm.tsx, the conversation status section should only be displayed when there are pending conversations (conversationCounts.pending !== 0). When all conversations are processed, no status information should be shown to keep the UI minimal and clean.
Learnt from: spashii
PR: Dembrane/echo#142
File: echo/frontend/src/lib/query.ts:680-696
Timestamp: 2025-05-13T15:20:25.165Z
Learning: In the Echo project, the conversation tags feature is designed with an implicit limit of 100 tags per conversation. Having more than 100 tags indicates a misuse of the feature rather than a limitation that needs to be addressed in the code. Errors for exceeding this limit should be handled at a logical level above the implementation.
Learnt from: ussaama
PR: Dembrane/echo#205
File: echo/frontend/src/lib/query.ts:1444-1506
Timestamp: 2025-07-10T12:48:20.683Z
Learning: ussaama prefers string concatenation over template literals for simple cases where readability is clearer, even when linting tools suggest template literals. Human readability takes precedence over strict linting rules in straightforward concatenation scenarios.
echo/frontend/src/routes/project/chat/ProjectChatRoute.tsx (2)

Learnt from: ussaama
PR: #224
File: echo/frontend/src/components/report/CreateReportForm.tsx:97-155
Timestamp: 2025-07-17T15:57:51.295Z
Learning: In echo/frontend/src/components/report/CreateReportForm.tsx, the conversation status section should only be displayed when there are pending conversations (conversationCounts.pending !== 0). When all conversations are processed, no status information should be shown to keep the UI minimal and clean.

Learnt from: ussaama
PR: #169
File: echo/frontend/src/components/project/ProjectPortalEditor.tsx:409-464
Timestamp: 2025-05-30T15:38:44.413Z
Learning: Badge-based selectors in ProjectPortalEditor.tsx: Keyboard navigation enhancements for accessibility are considered optional improvements rather than critical issues. The user acknowledges these suggestions but doesn't prioritize them as blockers.

🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ussaama
PR: Dembrane/echo#224
File: echo/frontend/src/components/report/CreateReportForm.tsx:97-155
Timestamp: 2025-07-17T15:57:51.295Z
Learning: In echo/frontend/src/components/report/CreateReportForm.tsx, the conversation status section should only be displayed when there are pending conversations (conversationCounts.pending !== 0). When all conversations are processed, no status information should be shown to keep the UI minimal and clean.
Learnt from: spashii
PR: Dembrane/echo#142
File: echo/frontend/src/lib/query.ts:680-696
Timestamp: 2025-05-13T15:20:25.165Z
Learning: In the Echo project, the conversation tags feature is designed with an implicit limit of 100 tags per conversation. Having more than 100 tags indicates a misuse of the feature rather than a limitation that needs to be addressed in the code. Errors for exceeding this limit should be handled at a logical level above the implementation.
Learnt from: ussaama
PR: Dembrane/echo#205
File: echo/frontend/src/lib/query.ts:1444-1506
Timestamp: 2025-07-10T12:48:20.683Z
Learning: ussaama prefers string concatenation over template literals for simple cases where readability is clearer, even when linting tools suggest template literals. Human readability takes precedence over strict linting rules in straightforward concatenation scenarios.
echo/frontend/src/routes/project/chat/ProjectChatRoute.tsx (2)

Learnt from: ussaama
PR: #224
File: echo/frontend/src/components/report/CreateReportForm.tsx:97-155
Timestamp: 2025-07-17T15:57:51.295Z
Learning: In echo/frontend/src/components/report/CreateReportForm.tsx, the conversation status section should only be displayed when there are pending conversations (conversationCounts.pending !== 0). When all conversations are processed, no status information should be shown to keep the UI minimal and clean.

Learnt from: ussaama
PR: #169
File: echo/frontend/src/components/project/ProjectPortalEditor.tsx:409-464
Timestamp: 2025-05-30T15:38:44.413Z
Learning: Badge-based selectors in ProjectPortalEditor.tsx: Keyboard navigation enhancements for accessibility are considered optional improvements rather than critical issues. The user acknowledges these suggestions but doesn't prioritize them as blockers.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: ci-check-server
🔇 Additional comments (1)
echo/frontend/src/routes/project/chat/ProjectChatRoute.tsx (1)

449-450: LGTM! Clean refactor that improves template discoverability.

Solid move removing the conditional logic - always showing the ChatTemplatesMenu provides consistent UX and eliminates complexity. The padding adjustment (py-2 → pb-2) also tightens up the visual spacing. This is exactly the kind of focused refactoring that makes the UI more predictable for users. 🚀

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ussaama ussaama enabled auto-merge July 23, 2025 07:40
@ussaama ussaama added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 6119824 Jul 23, 2025
12 checks passed
@ussaama ussaama deleted the chat-template-update branch July 23, 2025 08:59
spashii added a commit that referenced this pull request Jul 24, 2025
* Enhance conversation data handling by adding 'live' status (#234)

* Introduced a new 'live' field to the Conversation type to indicate ongoing activity based on recent chunks.
* Updated the useConversationsByProjectId hook to calculate the 'live' status for conversations.
* Modified ConversationAccordion component to display a visual indicator for live conversations.

* Update conversation filtering logic in components (#235)

* Refined the ConversationAccordion component to exclude conversations from the "CLONE" source when displaying live status indicators.
* Adjusted the OngoingConversationsSummaryCard to filter out both "DASHBOARD_UPLOAD" and "CLONE" sources for ongoing conversations, enhancing data accuracy and user experience.

* Refactor conversation status indicators and localization updates

* Updated the ConversationAccordion component to change the "Live" status label to "Ongoing" for better clarity.
* Adjusted the filtering logic in the useConversationsByProjectId hook to exclude only "DASHBOARD_UPLOAD" sources from recent chunks.
* Updated localization files for German, English, Spanish, French, and Dutch to reflect the new "Ongoing" status and ensure accurate mapping for conversation status messages.

* fix type issues

* fix issues

---------

Co-authored-by: Sameer Pashikanti <sameer@dembrane.com>
spashii pushed a commit that referenced this pull request Nov 18, 2025
Refactor ProjectChatRoute to always display ChatTemplatesMenu and simplify layout
spashii added a commit that referenced this pull request Nov 18, 2025
* Enhance conversation data handling by adding 'live' status (#234)

* Introduced a new 'live' field to the Conversation type to indicate ongoing activity based on recent chunks.
* Updated the useConversationsByProjectId hook to calculate the 'live' status for conversations.
* Modified ConversationAccordion component to display a visual indicator for live conversations.

* Update conversation filtering logic in components (#235)

* Refined the ConversationAccordion component to exclude conversations from the "CLONE" source when displaying live status indicators.
* Adjusted the OngoingConversationsSummaryCard to filter out both "DASHBOARD_UPLOAD" and "CLONE" sources for ongoing conversations, enhancing data accuracy and user experience.

* Refactor conversation status indicators and localization updates

* Updated the ConversationAccordion component to change the "Live" status label to "Ongoing" for better clarity.
* Adjusted the filtering logic in the useConversationsByProjectId hook to exclude only "DASHBOARD_UPLOAD" sources from recent chunks.
* Updated localization files for German, English, Spanish, French, and Dutch to reflect the new "Ongoing" status and ensure accurate mapping for conversation status messages.

* fix type issues

* fix issues

---------

Co-authored-by: Sameer Pashikanti <sameer@dembrane.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants