Skip to content

ECHO-378 "Request Access" instead of "Contact sales" #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ussaama merged 1 commit into from
Aug 12, 2025
Merged

ECHO-378 "Request Access" instead of "Contact sales" #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion echo/frontend/src/components/conversation/AutoSelectConversations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export const AutoSelectConversations = () => {
onClick={enableAutoSelect}
leftSection={<IconLock size={14} />}
>
<Trans>Contact sales</Trans>
<Trans>Request Access</Trans>
</Button>
Comment on lines +211 to 212
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Unify i18n: use explicit id for “Request Access”

Let’s reuse the same explicit key across the app to avoid duplicate PO entries and keep copy consistent.

Apply this diff here:

-            <Button
+            <Button
               size="xs"
               onClick={enableAutoSelect}
               leftSection={<IconLock size={14} />}
             >
-              <Trans>Request Access</Trans>
+              <Trans id="library.request.access">Request Access</Trans>
             </Button>

Follow-up:

  • We’re still emitting analytics events with old “CONTACT_SALES” names and using SalesLinks.AUTO_SELECT_CONTACT. If product analytics and messaging have shifted to “Request Access,” consider aligning event/link naming (see note below).
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Trans>Request Access</Trans>
</Button>
<Button
size="xs"
onClick={enableAutoSelect}
leftSection={<IconLock size={14} />}
>
<Trans id="library.request.access">Request Access</Trans>
</Button>
🤖 Prompt for AI Agents 
In echo/frontend/src/components/conversation/AutoSelectConversations.tsx around
lines 211-212, the literal <Trans>Request Access</Trans> should be changed to
use the app-wide explicit i18n key (e.g. <Trans
id="common.request_access">Request Access</Trans>) so the same key is reused
across the codebase; update the JSX to add the explicit id attribute with the
agreed key name, and run a quick grep across the repo to ensure the same id is
used elsewhere (and flag analytics/link constants separately if they also need
renaming).

</Stack>
</Box>
Expand Down
Loading