ECHO-421 fix "ECHO" button translation on portal

[MsVivienne]

Seeing if github still shows around 12 thousand changes while there have only been around 8?

Summary by CodeRabbit

• Style

  • Updated the recording-state label to “ECHO” in German, Spanish, French, and Dutch interfaces for consistent display.

• Chores

  • Removed or marked obsolete translation entries.
  • Minor formatting and whitespace cleanups in locale files.
  • Fixed a small locale export spacing issue.
  • Added contributor "MsVivienne" to the contributors list.

[coderabbitai]

Walkthrough

Locale strings for participant.button.is.recording.echo were standardized to "ECHO" in de-DE, es-ES, fr-FR, and nl-NL PO files; corresponding TS locale files saw minor formatting or spacing tweaks and an ES content sync. Some PO entries were marked obsolete.

Changes

Cohort / File(s)	Summary
PO locale text updates echo/frontend/src/locales/de-DE.po, echo/frontend/src/locales/es-ES.po, echo/frontend/src/locales/fr-FR.po, echo/frontend/src/locales/nl-NL.po	Update participant.button.is.recording.echo translation to ECHO; mark prior related entries as obsolete (#~).
TS locale content sync echo/frontend/src/locales/es-ES.ts	Change value for participant.button.is.recording.echo from "Echo" to "ECHO" inside the JSON payload.
TS minor syntax/formatting echo/frontend/src/locales/nl-NL.ts	Add space before type assertion in JSON.parse(...) as Messages (stylistic/syntax spacing).
TS formatting-only echo/frontend/src/locales/de-DE.ts, echo/frontend/src/locales/fr-FR.ts	Whitespace/formatting adjustments only; no runtime or API changes.
Metadata contributors.yml	Add contributor entry MsVivienne.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes — small, localized i18n text changes and minor formatting across a few files. LGTM.

Possibly related PRs

• ECHO-345 Participant portal UI/UX #256 — Modifies the same participant.button.is.recording.echo localization key across locale files.
• (dashboard) fix translations and audio preview #71 — Prior changes touching the same locale entries/files for the ECHO/recording-label translations.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The title "ECHO-421 fix "ECHO" button translation on portal" directly reflects the primary change in the diff — translation updates for participant.button.is.recording.echo that replace descriptive recording labels with the constant "ECHO" across multiple locale files. It is concise, specific to the visible UI change, and understandable to reviewers scanning PR history. This meets the project's guidance for clear, focused PR titles.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

echo/frontend/src/locales/es-ES.po (2)

211-214: Spanish grammar fix: “Todos los archivos”.

Correct article–noun agreement.

- msgstr "Todas las archivos se han subido correctamente."
+ msgstr "Todos los archivos se han subido correctamente."

---

898-901: Spanish grammar fix: “la nueva conversación”.

Natural phrasing and gender agreement.

- msgstr "Ingresa un nombre para el nuevo conversation"
+ msgstr "Ingresa un nombre para la nueva conversación"

echo/frontend/src/locales/de-DE.po (1)

791-798: Drop obsolete ECHO variants

Same cleanup note as FR: remove #~ obsolete “ECHO” entries to minimize diff noise.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8d16d0e and 31dad9a.

📒 Files selected for processing (8)

• echo/frontend/src/locales/de-DE.po (1 hunks)
• echo/frontend/src/locales/de-DE.ts (1 hunks)
• echo/frontend/src/locales/es-ES.po (1 hunks)
• echo/frontend/src/locales/es-ES.ts (1 hunks)
• echo/frontend/src/locales/fr-FR.po (1 hunks)
• echo/frontend/src/locales/fr-FR.ts (1 hunks)
• echo/frontend/src/locales/nl-NL.po (1 hunks)
• echo/frontend/src/locales/nl-NL.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: ussaama
PR: Dembrane/echo#266
File: echo/frontend/src/components/chat/ChatAccordion.tsx:214-221
Timestamp: 2025-08-19T10:14:31.647Z
Learning: In the Echo frontend codebase using Lingui, i18n IDs in Trans components (e.g., `<Trans id="any.string.here">`) can be arbitrary strings and don't need to follow specific naming conventions. They are just references used in .po files, and the actual translations need to be manually defined in the locale files.

📚 Learning: 2025-05-30T15:36:40.131Z

Learnt from: ussaama
PR: Dembrane/echo#169
File: echo/frontend/src/locales/fr-FR.po:521-523
Timestamp: 2025-05-30T15:36:40.131Z
Learning: In the French localization file (fr-FR.po), "Dembrane Echo" is intentionally translated as "Echo Dembrane" for better French language flow and natural sound. This is not an error but a deliberate localization choice.

Applied to files:

• echo/frontend/src/locales/fr-FR.po

🧬 Code graph analysis (3)

echo/frontend/src/locales/de-DE.ts (1)

echo/frontend/src/locales/en-US.ts (1)

• messages (1-1)

echo/frontend/src/locales/fr-FR.ts (1)

echo/frontend/src/locales/en-US.ts (1)

• messages (1-1)

echo/frontend/src/locales/nl-NL.ts (4)

echo/frontend/src/locales/de-DE.ts (1)

• messages (1-1)

echo/frontend/src/locales/es-ES.ts (1)

• messages (1-1)

echo/frontend/src/locales/fr-FR.ts (1)

• messages (1-1)

echo/frontend/src/locales/en-US.ts (1)

• messages (1-1)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Cursor Bugbot

🔇 Additional comments (9)

echo/frontend/src/locales/es-ES.po (1)

789-792: LGTM — recording label standardized to "ECHO"; non-recording label remains "Echo" in es-ES.

Verified participant.button.is.recording.echo == "ECHO" in en-US, es-ES, fr-FR, nl-NL, de-DE; participant.button.echo == "Echo" in es-ES.

echo/frontend/src/locales/nl-NL.ts (1)

1-1: Tiny TS cast spacing tweak — LGTM.

No functional impact; keeps as Messages readable. Also confirms "participant.button.is.recording.echo": "ECHO" for NL.

echo/frontend/src/locales/de-DE.ts (1)

1-1: Formatting-only change — LGTM. Also, confirm brand casing for normal state.

Recording-state is “ECHO” (good). The normal-state label (participant.button.echo) appears as “Echo” here, while en-US uses “ECHO”. If brand guidelines require all-caps, align DE (and others); otherwise, keep as-is.

echo/frontend/src/locales/es-ES.ts (1)

1-1: es-ES compiled messages — ECHO change LGTM.

Matches the PO update for recording-state. After fixing the PO grammar items, re-generate to keep this compiled bundle in sync.

echo/frontend/src/locales/fr-FR.po (2)

791-791: LGTM: standardized to brand “ECHO” for recording state

Matches the cross-locale intent; brand-consistent. Ship it.

---

793-797: Purge obsolete '#~' ÉCHO entries from fr-FR.po

Verified: echo/frontend/src/locales/fr-FR.po still contains obsolete #~ msgid/msgstr for "ÉCHO"; participant.button.is.recording.echo is actively mapped to "ECHO" in fr-FR (and nl/en-US/de/es) and no active "ÉCHO" remains — remove the #~ lines and run npx lingui extract --clean && npx lingui compile in this branch before merge. LGTM.

echo/frontend/src/locales/de-DE.po (1)

787-787: LGTM: “ECHO” unified for is-recording state

Consistent with other locales. Good to go.

echo/frontend/src/locales/nl-NL.po (2)

903-905: Standardizing to brand “ECHO” — LGTM

The casing change on the recording-state label aligns with branding and matches the cross-locale intent. Ship it.

---

897-905: Confirm casing: "Echo" (idle) vs "ECHO" (recording)

• Findings: nl-NL, fr-FR, de-DE, es-ES — participant.button.echo = "Echo", participant.button.is.recording.echo = "ECHO". en-US — both keys = "ECHO" (outlier).
• Action: Confirm intended casing and normalize across locales (notably echo/frontend/src/locales/en-US.po if idle label should be title-case). LGTM.

[coderabbitai]

💡 Verification agent

🧩 Analysis chain

Inconsistent “ECHO” vs “ÉCHO” in FR.

This file includes participant.button.is.recording.echo: "ECHO" and another key mapping to "ÉCHO". Pick one (likely “ECHO”) to avoid UI drift and search ambiguity.

To locate and normalize:

---

🏁 Script executed:

#!/bin/bash
rg -n --glob "echo/frontend/src/locales/fr-FR.*" '"ÉCHO"|\"ECHO\"'

Length of output: 88

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "1) List fr-FR locale files under echo/frontend/src/locales:"
rg -n --files -g 'echo/frontend/src/locales/**' 'fr-FR' || true
echo

echo "2) Find occurrences of quoted \"ECHO\" / \"ÉCHO\" in locales:"
rg -n -S -F -e '"ECHO"' -e '"ÉCHO"' -g 'echo/frontend/src/locales/**' || true
echo

echo "3) Find unquoted occurrences (ECHO, ÉCHO, ECHO!) in frontend sources:"
rg -n -S -F -e 'ÉCHO' -e 'ECHO!' -e 'ECHO' -g 'echo/frontend/src/**' --hidden --no-ignore-vcs || true
echo

echo "4) Show lines for participant.button.is.recording.echo key:"
rg -n -S 'participant.button.is.recording.echo' -g 'echo/frontend/src/**' || true

Length of output: 305539

---

Normalize FR 'ECHO' → use ASCII "ECHO"

Most locales use "ECHO"; fr-FR contains both "ECHO" and "ÉCHO" — unify to "ECHO" to avoid UI/search drift.

• Update echo/frontend/src/locales/fr-FR.ts: change HA9VXi value from "ÉCHO" → "ECHO" (participant.button.is.recording.echo is already "ECHO").
• Clean up fr PO: echo/frontend/src/locales/fr-FR.po — remove/update the stale/commented #~ msgstr "ÉCHO" (around line ~796) so the active msgstr is "ECHO".
• Rebuild/regenerate locale artifacts if .ts files are generated from .po.

🤖 Prompt for AI Agents

In echo/frontend/src/locales/fr-FR.ts around lines 1–1, the French messages
include both "ÉCHO" and "ECHO" which causes inconsistency; change the value for
key HA9VXi from "ÉCHO" to ASCII "ECHO" to match
participant.button.is.recording.echo, then open
echo/frontend/src/locales/fr-FR.po (around line ~796) and remove or update the
stale/commented #~ msgstr "ÉCHO" so the active msgstr is "ECHO"; finally
rebuild/regenerate the locale artifacts if the .ts is generated from .po files.

[coderabbitai]

🧹 Nitpick (assertive)

Add a translator note to lock the brand (prevents future regressions)

Make it explicit that “ECHO” is a non-translatable brand and should remain uppercase.

 #. js-lingui-explicit-id
 #: src/routes/participant/ParticipantConversation.tsx:645
 msgid "participant.button.is.recording.echo"
+##. Translators: Brand label; do not translate. Keep as "ECHO" (uppercase).
 msgstr "ECHO"

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents

In echo/frontend/src/locales/nl-NL.po around lines 902–905, add a translator
note immediately above the msgid/msgstr to state that "ECHO" is a branded term
that must not be translated and must remain uppercase; keep msgstr as "ECHO" and
ensure the comment clearly instructs translators to lock the brand to prevent
future regressions.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 31dad9a and b7d0bc1.

📒 Files selected for processing (1)

• contributors.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Cursor Bugbot

🔇 Additional comments (1)

contributors.yml (1)

7-7: LGTM — clean contributor add.
Format matches existing list. Welcome, MsVivienne.