ECHO-488 update options for transcription#297
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdjusts AssemblyAI transcription request to use language_detection with expanded options and fallback_language logic; updates logging and raised error formatting in transcribe_conversation_chunk. No public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| data["language_detection_options"]["fallback_language"] = "en" | ||
| else: | ||
| data["language_code"] = language | ||
| data["language_detection_options"]["fallback_language"] = language |
There was a problem hiding this comment.
Bug: Audio Transcription Language Detection Issue
The transcribe_audio_assemblyai function now unconditionally enables language detection. This means a specified language is used only as a fallback, altering the expected behavior of directly forcing a language. Additionally, if language is None, detection is enabled without a fallback, which may cause API errors.
Summary by CodeRabbit