Skip to content

ECHO-488 update options for transcription#297

Merged
spashii merged 1 commit intomainfrom
fix-transcription-language-options
Sep 16, 2025
Merged

ECHO-488 update options for transcription#297
spashii merged 1 commit intomainfrom
fix-transcription-language-options

Conversation

@spashii
Copy link
Copy Markdown
Member

@spashii spashii commented Sep 16, 2025

Summary by CodeRabbit

  • New Features
    • Improved language detection with configurable fallback: auto-detected language now defaults to English when unspecified, or uses the selected language as fallback for more accurate transcriptions.
  • Bug Fixes
    • Clearer, more consistent error messages during transcription failures, improving troubleshooting and reliability.

@spashii spashii requested a review from ussaama September 16, 2025 16:04
@linear
Copy link
Copy Markdown

linear bot commented Sep 16, 2025

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adjusts AssemblyAI transcription request to use language_detection with expanded options and fallback_language logic; updates logging and raised error formatting in transcribe_conversation_chunk. No public API changes.

Changes

Cohort / File(s) Summary of changes
Transcription payload & logging
echo/server/dembrane/transcribe.py
Switched to top-level language_detection: True with expanded language_detection_options.expected_languages and fallback_language selection (auto→en or specific language). Replaced language_code usage. Updated logger.error and TranscriptionError messages to use parameterized formatting instead of f-strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Feature

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-transcription-language-options

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 541061c and 280f6e1.

📒 Files selected for processing (1)
  • echo/server/dembrane/transcribe.py (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@spashii spashii merged commit b72a77b into main Sep 16, 2025
9 of 10 checks passed
@spashii spashii deleted the fix-transcription-language-options branch September 16, 2025 16:05
@coderabbitai coderabbitai bot added the Feature label Sep 16, 2025
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

data["language_detection_options"]["fallback_language"] = "en"
else:
data["language_code"] = language
data["language_detection_options"]["fallback_language"] = language
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Audio Transcription Language Detection Issue

The transcribe_audio_assemblyai function now unconditionally enables language detection. This means a specified language is used only as a fallback, altering the expected behavior of directly forcing a language. Additionally, if language is None, detection is enabled without a fallback, which may cause API errors.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant