Skip to content

ECHO-472 Library translations fix #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ussaama merged 1 commit into from
Sep 18, 2025
Merged

ECHO-472 Library translations fix #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions echo/frontend/src/locales/de-DE.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ msgstr "Etwas ist schief gelaufen"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Gespräche werden verarbeitet"
#~ msgstr "Derzeit sind {finishedConversationsCount} Gespräche bereit zur Analyse. {unfinishedConversationsCount} werden noch verarbeitet."

Comment on lines 46 to 50
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick

Remove obsolete entry instead of updating it.

#~ library.conversations.processing.status is marked obsolete but its msgstr was edited. Kill obsolete strings to avoid translator drift and accidental resurrection.

Apply:

-#. js-lingui-explicit-id
-#: src/routes/project/library/ProjectLibrary.tsx:236
-#~ msgid "library.conversations.processing.status"
-#~ msgstr "Derzeit sind {finishedConversationsCount} Gespräche bereit zur Analyse. {unfinishedConversationsCount} werden noch verarbeitet."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Gespräche werden verarbeitet"
#~ msgstr "Derzeit sind {finishedConversationsCount} Gespräche bereit zur Analyse. {unfinishedConversationsCount} werden noch verarbeitet."
🤖 Prompt for AI Agents 
In echo/frontend/src/locales/de-DE.po around lines 46 to 50, the entry beginning
with "#~ msgid "library.conversations.processing.status"" is obsolete but was
edited; remove the entire obsolete block (the "#~" lines including msgid and
msgstr and any related comment lines) rather than updating its msgstr, then save
the .po so it remains syntactically valid and run your i18n lint/msgfmt check to
ensure no leftover or duplicate entries remain.

#. js-lingui-explicit-id
#: src/components/participant/EchoErrorAlert.tsx:14
Expand Down Expand Up @@ -125,7 +125,7 @@ msgstr "{0} Gespräche • Bearbeitet {1}"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "Aktuell {0} Gespräche sind bereit, um analysiert zu werden."
msgstr "{finishedConversationsCount, plural, one {Derzeit ist # Unterhaltung bereit zur Analyse.} other {Derzeit sind # Unterhaltungen bereit zur Analyse.}}"

Comment on lines 126 to 129
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick

Unify term: use “Gespräch/Gespräche”, fix article/order.

Elsewhere this locale uses “Gespräch”. Also improve phrasing.

Apply:

-msgstr "{finishedConversationsCount, plural, one {Derzeit ist # Unterhaltung bereit zur Analyse.} other {Derzeit sind # Unterhaltungen bereit zur Analyse.}}"
+msgstr "{finishedConversationsCount, plural, one {Derzeit ist # Gespräch zur Analyse bereit.} other {Derzeit sind # Gespräche zur Analyse bereit.}}"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "Aktuell {0} Gespräche sind bereit, um analysiert zu werden."
msgstr "{finishedConversationsCount, plural, one {Derzeit ist # Unterhaltung bereit zur Analyse.} other {Derzeit sind # Unterhaltungen bereit zur Analyse.}}"
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "{finishedConversationsCount, plural, one {Derzeit ist # Gespräch zur Analyse bereit.} other {Derzeit sind # Gespräche zur Analyse bereit.}}"
🤖 Prompt for AI Agents 
In echo/frontend/src/locales/de-DE.po around lines 126 to 129, the translation
uses “Unterhaltung/Unterhaltungen” and awkward word order; change to the
project's preferred term “Gespräch/Gespräche” and correct article/order and
phrasing. Update the pluralized msgstr so the singular reads like “Derzeit ist
ein Gespräch bereit zur Analyse.” and the plural reads like “Derzeit sind
{finishedConversationsCount} Gespräche bereit zur Analyse.”, preserving the ICU
plural placeholder and punctuation.

#: src/routes/participant/ParticipantConversation.tsx:253
msgid "{minutes} minutes and {seconds} seconds"
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/de-DE.ts
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/en-US.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions echo/frontend/src/locales/es-ES.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ msgstr "Algo salió mal"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Conversaciones en proceso"
#~ msgstr "Actualmente, {finishedConversationsCount} conversaciones están listas para ser analizadas. {unfinishedConversationsCount} aún en proceso."

Comment on lines 47 to 50
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick

Drop obsolete entry to avoid translator churn

#~ library.conversations.processing.status is marked obsolete but still carries a non-ICU sentence. Remove it to reduce confusion.

-#~ msgid "library.conversations.processing.status"
-#~ msgstr "Actualmente, {finishedConversationsCount} conversaciones están listas para ser analizadas. {unfinishedConversationsCount} aún en proceso."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Conversaciones en proceso"
#~ msgstr "Actualmente, {finishedConversationsCount} conversaciones están listas para ser analizadas. {unfinishedConversationsCount} aún en proceso."
#: src/routes/project/library/ProjectLibrary.tsx:236
🤖 Prompt for AI Agents 
In echo/frontend/src/locales/es-ES.po around lines 47 to 50, the entry for
library.conversations.processing.status is marked obsolete (prefixed with #~)
but remains in the file and contains a non-ICU sentence; remove the entire
obsolete block (the lines starting with #~, the msgid and msgstr for
library.conversations.processing.status) so translators won't see or edit it and
to avoid confusion with ICU formatting.

#. js-lingui-explicit-id
#: src/components/participant/EchoErrorAlert.tsx:14
Expand Down Expand Up @@ -125,7 +125,7 @@ msgstr "{0} Conversaciones • Editado {1}"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "Actualmente {0} conversaciones están listas para ser analizadas."
msgstr "{finishedConversationsCount, plural, one {Actualmente, # conversación está lista para ser analizada.} other {Actualmente, # conversaciones están listas para ser analizadas.}}"

#: src/routes/participant/ParticipantConversation.tsx:253
msgid "{minutes} minutes and {seconds} seconds"
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/es-ES.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions echo/frontend/src/locales/fr-FR.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ msgstr "Une erreur s'est produite"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Conversations en cours de traitement"
#~ msgstr "Actuellement, {finishedConversationsCount} conversations sont prêtes à être analysées. {unfinishedConversationsCount} sont encore en cours de traitement."

Comment on lines 47 to 50
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick

Purge obsolete status entry

Same rationale as ES: remove #~ library.conversations.processing.status.

-#~ msgid "library.conversations.processing.status"
-#~ msgstr "Actuellement, {finishedConversationsCount} conversations sont prêtes à être analysées. {unfinishedConversationsCount} sont encore en cours de traitement."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Conversations en cours de traitement"
#~ msgstr "Actuellement, {finishedConversationsCount} conversations sont prêtes à être analysées. {unfinishedConversationsCount} sont encore en cours de traitement."
#: src/routes/project/library/ProjectLibrary.tsx:236
🤖 Prompt for AI Agents 
In echo/frontend/src/locales/fr-FR.po around lines 47 to 50, there is an
obsolete/commented translation entry (#~ msgid and #~ msgstr) for
"library.conversations.processing.status"; remove these four lines entirely so
the obsolete entry is purged and ensure no leftover #~ markers remain in the
file.

#. js-lingui-explicit-id
#: src/components/participant/EchoErrorAlert.tsx:14
Expand Down Expand Up @@ -125,7 +125,7 @@ msgstr "{0} Conversations • Modifié le {1}"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "Actuellement {0} conversations sont prêtes à être analysées."
msgstr "{finishedConversationsCount, plural, one {Actuellement, # conversation est prête à être analysée.} other {Actuellement, # conversations sont prêtes à être analysées.}}"

#: src/routes/participant/ParticipantConversation.tsx:253
msgid "{minutes} minutes and {seconds} seconds"
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/fr-FR.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions echo/frontend/src/locales/nl-NL.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ msgstr "Er is iets fout gegaan"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Gesprekken worden verwerkt"
#~ msgstr "Momenteel zijn {finishedConversationsCount} gesprekken klaar om geanalyseerd te worden. {unfinishedConversationsCount} worden nog verwerkt."

Comment on lines 46 to 50
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick

Drop obsolete key instead of translating it.

#~ library.conversations.processing.status is obsolete; keep catalogs clean.

Apply:

-#. js-lingui-explicit-id
-#: src/routes/project/library/ProjectLibrary.tsx:236
-#~ msgid "library.conversations.processing.status"
-#~ msgstr "Momenteel zijn {finishedConversationsCount} gesprekken klaar om geanalyseerd te worden. {unfinishedConversationsCount} worden nog verwerkt."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:236
#~ msgid "library.conversations.processing.status"
#~ msgstr "Gesprekken worden verwerkt"
#~ msgstr "Momenteel zijn {finishedConversationsCount} gesprekken klaar om geanalyseerd te worden. {unfinishedConversationsCount} worden nog verwerkt."
🤖 Prompt for AI Agents 
In echo/frontend/src/locales/nl-NL.po around lines 46 to 50, the entry for the
obsolete key "library.conversations.processing.status" is marked with #~ and
should be removed rather than translated; delete the obsolete block (including
the #~ msgid/msgstr lines and any related comment markers) so the catalog no
longer contains that deprecated key.

#. js-lingui-explicit-id
#: src/components/participant/EchoErrorAlert.tsx:14
Expand Down Expand Up @@ -125,7 +125,7 @@ msgstr "{0} Gesprekken • Bewerkt {1}"
#. js-lingui-explicit-id
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "Er zijn {0} gesprekken klaar om te worden geanalyseerd."
msgstr "{finishedConversationsCount, plural, one {Momenteel is # gesprek klaar om te worden geanalyseerd.} other {Momenteel zijn # gesprekken klaar om te worden geanalyseerd.}}"

Comment on lines 126 to 129
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick

ICU plural LGTM (minor style nit).

Works correctly. Optional: “klaar voor analyse” reads cleaner.

Optional:

-msgstr "{finishedConversationsCount, plural, one {Momenteel is # gesprek klaar om te worden geanalyseerd.} other {Momenteel zijn # gesprekken klaar om te worden geanalyseerd.}}"
+msgstr "{finishedConversationsCount, plural, one {Momenteel is # gesprek klaar voor analyse.} other {Momenteel zijn # gesprekken klaar voor analyse.}}"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "Er zijn {0} gesprekken klaar om te worden geanalyseerd."
msgstr "{finishedConversationsCount, plural, one {Momenteel is # gesprek klaar om te worden geanalyseerd.} other {Momenteel zijn # gesprekken klaar om te worden geanalyseerd.}}"
#: src/routes/project/library/ProjectLibrary.tsx:240
msgid "library.conversations.to.be.analyzed"
msgstr "{finishedConversationsCount, plural, one {Momenteel is # gesprek klaar voor analyse.} other {Momenteel zijn # gesprekken klaar voor analyse.}}"
🤖 Prompt for AI Agents 
In echo/frontend/src/locales/nl-NL.po around lines 126 to 129, the ICU plural
message is correct but the wording can be improved: change the msgstr phrasing
from "Momenteel is/ zijn # gesprek(en) klaar om te worden geanalyseerd." to a
cleaner variant using "klaar voor analyse" (e.g. "{finishedConversationsCount,
plural, one {Momenteel is # gesprek klaar voor analyse.} other {Momenteel zijn #
gesprekken klaar voor analyse.}}") so update the msgstr accordingly while
preserving the ICU plural structure and interpolation.

#: src/routes/participant/ParticipantConversation.tsx:253
msgid "{minutes} minutes and {seconds} seconds"
Expand Down
2 changes: 1 addition & 1 deletion echo/frontend/src/locales/nl-NL.ts
View file
Open in desktop

Large diffs are not rendered by default.