Skip to content

Added an X button next to Tags to reset sorting and tag filteringin the admin dashboard for conversations#311

Closed
MsVivienne wants to merge 2 commits intoDembrane:mainfrom
MsVivienne:Added-'X'-button-next-to-'Tags'-option-in-admin-dashboard-for-conversations-
Closed

Added an X button next to Tags to reset sorting and tag filteringin the admin dashboard for conversations#311
MsVivienne wants to merge 2 commits intoDembrane:mainfrom
MsVivienne:Added-'X'-button-next-to-'Tags'-option-in-admin-dashboard-for-conversations-

Conversation

@MsVivienne
Copy link
Copy Markdown
Contributor

@MsVivienne MsVivienne commented Sep 26, 2025

Summary by CodeRabbit

  • New Features
    • Added a compact “Reset to default” icon with tooltip next to filters, preserving existing reset behavior and improving accessibility via aria-label.
  • Style
    • Replaced the previous full-size reset button with an outline icon to streamline the sort/filter UI.
  • Chores
    • Added “Reset to default” translations for de, en, es, fr, and nl.
    • Updated locale bundles and formatting with no functional changes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 26, 2025

Walkthrough

Moves the reset control in ConversationAccordion from an inline dropdown button to a persistent tooltip-wrapped outline ActionIcon that calls resetEverything, and adds the i18n key "Reset to default" with translations across locales. Locale TS bundles receive minor formatting/type-import adjustments only.

Changes

Cohort / File(s) Summary of Changes
Conversation UI control update
echo/frontend/src/components/conversation/ConversationAccordion.tsx
Removes inline "Reset All Options" button from sort UI and adds a persistent outline ActionIcon (X) wrapped in a Tooltip that invokes resetEverything; adds aria-label and keeps existing sort/filter logic.
Localization strings (.po)
echo/frontend/src/locales/en-US.po, echo/frontend/src/locales/de-DE.po, echo/frontend/src/locales/es-ES.po, echo/frontend/src/locales/fr-FR.po, echo/frontend/src/locales/nl-NL.po
Adds msgid "Reset to default" and locale-specific translations with source references to ConversationAccordion.
Localization bundles (.ts)
echo/frontend/src/locales/en-US.ts, echo/frontend/src/locales/de-DE.ts, echo/frontend/src/locales/es-ES.ts, echo/frontend/src/locales/nl-NL.ts
Minor formatting/type-import edits; exports and runtime behavior unchanged (JSON-parsed Messages remain the same).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

improvement

LGTM.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately describes the primary change by highlighting the addition of an X button adjacent to the Tags filter in the admin dashboard conversation view to reset sorting and tag filters, matching the implemented feature and scope.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 31ab10b and 2680592.

📒 Files selected for processing (1)
  • echo/frontend/src/components/conversation/ConversationAccordion.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: ci-build-servers (dbr-echo-directus, ./echo/directus, Dockerfile, dbr-echo-directus)
  • GitHub Check: ci-build-servers (dbr-echo-server, ./echo/server, Dockerfile, dbr-echo-server)
🔇 Additional comments (1)
echo/frontend/src/components/conversation/ConversationAccordion.tsx (1)

1101-1109: LGTM – slick reset affordance

Reset ActionIcon is tight: tooltip, aria-label, and the callback snap everything back without regressing styling (thanks for flipping the Mantine token to gray). Ship it.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f28c547 and 31ab10b.

📒 Files selected for processing (10)
  • echo/frontend/src/components/conversation/ConversationAccordion.tsx (1 hunks)
  • echo/frontend/src/locales/de-DE.po (1 hunks)
  • echo/frontend/src/locales/de-DE.ts (1 hunks)
  • echo/frontend/src/locales/en-US.po (1 hunks)
  • echo/frontend/src/locales/en-US.ts (1 hunks)
  • echo/frontend/src/locales/es-ES.po (1 hunks)
  • echo/frontend/src/locales/es-ES.ts (1 hunks)
  • echo/frontend/src/locales/fr-FR.po (1 hunks)
  • echo/frontend/src/locales/nl-NL.po (1 hunks)
  • echo/frontend/src/locales/nl-NL.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (3)
echo/frontend/src/locales/nl-NL.ts (4)
echo/frontend/src/locales/de-DE.ts (1)
  • messages (1-1)
echo/frontend/src/locales/en-US.ts (1)
  • messages (1-1)
echo/frontend/src/locales/es-ES.ts (1)
  • messages (1-1)
echo/frontend/src/locales/fr-FR.ts (1)
  • messages (1-1)
echo/frontend/src/locales/en-US.ts (4)
echo/frontend/src/locales/de-DE.ts (1)
  • messages (1-1)
echo/frontend/src/locales/es-ES.ts (1)
  • messages (1-1)
echo/frontend/src/locales/nl-NL.ts (1)
  • messages (1-1)
echo/frontend/src/locales/fr-FR.ts (1)
  • messages (1-1)
echo/frontend/src/locales/de-DE.ts (3)
echo/frontend/src/locales/en-US.ts (1)
  • messages (1-1)
echo/frontend/src/locales/nl-NL.ts (1)
  • messages (1-1)
echo/frontend/src/locales/fr-FR.ts (1)
  • messages (1-1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: ci-build-servers (dbr-echo-directus, ./echo/directus, Dockerfile, dbr-echo-directus)
  • GitHub Check: ci-build-servers (dbr-echo-server, ./echo/server, Dockerfile, dbr-echo-server)
🔇 Additional comments (9)
echo/frontend/src/locales/en-US.ts (1)

2682-2686: Localized reset key lands perfectly

LGTM. The new message id and string align with the icon-button reset UX. Ship it.

echo/frontend/src/locales/nl-NL.po (1)

2682-2686: Dutch string dialed in

LGTM. “Resetten naar standaard” maps cleanly to the new action without regressing existing tags UX.

echo/frontend/src/locales/en-US.po (1)

2528-2532: US locale in sync

LGTM. Source and translation stay identical so the new control renders cleanly.

echo/frontend/src/locales/fr-FR.po (1)

2470-2473: LGTM on the new FR string.

"Réinitialiser aux paramètres par défaut" nails the intent for the reset tooltip. All good here.

echo/frontend/src/locales/de-DE.po (1)

2459-2463: Translation locked in.

"Auf Standard zurücksetzen" reads crisply in German for the reset icon. Ship it.

echo/frontend/src/locales/nl-NL.ts (1)

3174-3174: Ship it – Dutch reset copy synced perfectly

L+rMC9 now resolves to “Resetten naar standaard”, lining up with the new ActionIcon UX. No flags here.

echo/frontend/src/locales/de-DE.ts (1)

3174-3174: All green – DE locale wired to the new reset affordance

“Auf Standard zurücksetzen” is spot-on for the fresh tooltip/button. Nothing else to tweak.

echo/frontend/src/locales/es-ES.po (1)

2470-2474: Looks tight – PO catalog carries the new reset string

msgid "Reset to default"msgstr "Restablecer a valores predeterminados" keeps the Spanish catalog aligned with the UI update.

echo/frontend/src/locales/es-ES.ts (1)

3175-3175: Synced – ES messages JSON mirrors the PO addition

The compiled bundle exports the same “Restablecer a valores predeterminados” payload, so runtime lookups are good to go.

@spashii
Copy link
Copy Markdown
Member

spashii commented Sep 29, 2025

@ussaama please review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants