Added an X button next to Tags to reset sorting and tag filteringin the admin dashboard for conversations#311
Conversation
…he admin dashboard for conversations
WalkthroughMoves the reset control in ConversationAccordion from an inline dropdown button to a persistent tooltip-wrapped outline ActionIcon that calls Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
LGTM. Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
echo/frontend/src/components/conversation/ConversationAccordion.tsx(1 hunks)echo/frontend/src/locales/de-DE.po(1 hunks)echo/frontend/src/locales/de-DE.ts(1 hunks)echo/frontend/src/locales/en-US.po(1 hunks)echo/frontend/src/locales/en-US.ts(1 hunks)echo/frontend/src/locales/es-ES.po(1 hunks)echo/frontend/src/locales/es-ES.ts(1 hunks)echo/frontend/src/locales/fr-FR.po(1 hunks)echo/frontend/src/locales/nl-NL.po(1 hunks)echo/frontend/src/locales/nl-NL.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (3)
echo/frontend/src/locales/nl-NL.ts (4)
echo/frontend/src/locales/de-DE.ts (1)
messages(1-1)echo/frontend/src/locales/en-US.ts (1)
messages(1-1)echo/frontend/src/locales/es-ES.ts (1)
messages(1-1)echo/frontend/src/locales/fr-FR.ts (1)
messages(1-1)
echo/frontend/src/locales/en-US.ts (4)
echo/frontend/src/locales/de-DE.ts (1)
messages(1-1)echo/frontend/src/locales/es-ES.ts (1)
messages(1-1)echo/frontend/src/locales/nl-NL.ts (1)
messages(1-1)echo/frontend/src/locales/fr-FR.ts (1)
messages(1-1)
echo/frontend/src/locales/de-DE.ts (3)
echo/frontend/src/locales/en-US.ts (1)
messages(1-1)echo/frontend/src/locales/nl-NL.ts (1)
messages(1-1)echo/frontend/src/locales/fr-FR.ts (1)
messages(1-1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ci-build-servers (dbr-echo-directus, ./echo/directus, Dockerfile, dbr-echo-directus)
- GitHub Check: ci-build-servers (dbr-echo-server, ./echo/server, Dockerfile, dbr-echo-server)
🔇 Additional comments (9)
echo/frontend/src/locales/en-US.ts (1)
2682-2686: Localized reset key lands perfectlyLGTM. The new message id and string align with the icon-button reset UX. Ship it.
echo/frontend/src/locales/nl-NL.po (1)
2682-2686: Dutch string dialed inLGTM. “Resetten naar standaard” maps cleanly to the new action without regressing existing tags UX.
echo/frontend/src/locales/en-US.po (1)
2528-2532: US locale in syncLGTM. Source and translation stay identical so the new control renders cleanly.
echo/frontend/src/locales/fr-FR.po (1)
2470-2473: LGTM on the new FR string."Réinitialiser aux paramètres par défaut" nails the intent for the reset tooltip. All good here.
echo/frontend/src/locales/de-DE.po (1)
2459-2463: Translation locked in."Auf Standard zurücksetzen" reads crisply in German for the reset icon. Ship it.
echo/frontend/src/locales/nl-NL.ts (1)
3174-3174: Ship it – Dutch reset copy synced perfectly
L+rMC9now resolves to “Resetten naar standaard”, lining up with the new ActionIcon UX. No flags here.echo/frontend/src/locales/de-DE.ts (1)
3174-3174: All green – DE locale wired to the new reset affordance“Auf Standard zurücksetzen” is spot-on for the fresh tooltip/button. Nothing else to tweak.
echo/frontend/src/locales/es-ES.po (1)
2470-2474: Looks tight – PO catalog carries the new reset string
msgid "Reset to default"→msgstr "Restablecer a valores predeterminados"keeps the Spanish catalog aligned with the UI update.echo/frontend/src/locales/es-ES.ts (1)
3175-3175: Synced – ES messages JSON mirrors the PO additionThe compiled bundle exports the same “Restablecer a valores predeterminados” payload, so runtime lookups are good to go.
|
@ussaama please review this |
Summary by CodeRabbit