Skip to content

Added an x button next to tags to reset sorting and tag filteringin the admin dashboard for conversations conflicts fixed#313

Closed
MsVivienne wants to merge 2 commits intoDembrane:mainfrom
MsVivienne:Added-an-X-button-next-to-Tags-to-reset-sorting-and-tag-filteringin-the-admin-dashboard-for-conversations-conflicts-fixed
Closed

Added an x button next to tags to reset sorting and tag filteringin the admin dashboard for conversations conflicts fixed#313
MsVivienne wants to merge 2 commits intoDembrane:mainfrom
MsVivienne:Added-an-X-button-next-to-Tags-to-reset-sorting-and-tag-filteringin-the-admin-dashboard-for-conversations-conflicts-fixed

Conversation

@MsVivienne
Copy link
Copy Markdown
Contributor

@MsVivienne MsVivienne commented Sep 29, 2025

Hopefully the conflicts have been resolved...?

Summary by CodeRabbit

  • New Features
    • Added a “Reset to default” icon button with tooltip in conversation filters (replaces “Reset All Options”), preserving existing reset behavior.
  • Style
    • Moved the reset control alongside Sort and Tags menus for quicker access and a cleaner UI.
  • Chores
    • Added translations for “Reset to default” in German, English, Spanish, French, and Dutch; minor locale file adjustments.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced the “Reset All Options” button with a tooltip-wrapped icon button in ConversationAccordion, invoking the existing resetEverything handler. Added “Reset to default” translations across de, en, es, fr, and nl locales. Minor locale TS updates, including an eslint-disable in es-ES.ts; others effectively unchanged.

Changes

Cohort / File(s) Summary
Conversation UI control update
echo/frontend/src/components/conversation/ConversationAccordion.tsx
Replaced text reset button with tooltip icon button; retained resetEverything handler; adjusted placement alongside Sort and Tags.
Locale translations (.po) additions
echo/frontend/src/locales/de-DE.po, echo/frontend/src/locales/en-US.po, echo/frontend/src/locales/es-ES.po, echo/frontend/src/locales/fr-FR.po, echo/frontend/src/locales/nl-NL.po
Added new msgid “Reset to default” with locale-specific translations; referenced ConversationAccordion.tsx source lines.
Locale TS files — no functional changes
echo/frontend/src/locales/de-DE.ts, echo/frontend/src/locales/en-US.ts, echo/frontend/src/locales/nl-NL.ts
No behavioral changes; content effectively identical before/after.
Locale TS lint tweak
echo/frontend/src/locales/es-ES.ts
Added /* eslint-disable */ directive; no runtime changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

improvement

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 02584ed and 2680592.

📒 Files selected for processing (10)
  • echo/frontend/src/components/conversation/ConversationAccordion.tsx (1 hunks)
  • echo/frontend/src/locales/de-DE.po (1 hunks)
  • echo/frontend/src/locales/de-DE.ts (1 hunks)
  • echo/frontend/src/locales/en-US.po (1 hunks)
  • echo/frontend/src/locales/en-US.ts (1 hunks)
  • echo/frontend/src/locales/es-ES.po (1 hunks)
  • echo/frontend/src/locales/es-ES.ts (1 hunks)
  • echo/frontend/src/locales/fr-FR.po (1 hunks)
  • echo/frontend/src/locales/nl-NL.po (1 hunks)
  • echo/frontend/src/locales/nl-NL.ts (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MsVivienne MsVivienne closed this Sep 29, 2025
@MsVivienne MsVivienne deleted the Added-an-X-button-next-to-Tags-to-reset-sorting-and-tag-filteringin-the-admin-dashboard-for-conversations-conflicts-fixed branch September 29, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant