Skip to content

ECHO-334 Implement biome rules #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spashii merged 9 commits into from
Oct 20, 2025
Merged

ECHO-334 Implement biome rules #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8b15f98
- biome rules updated
ussaama Oct 15, 2025
8d70d1b
- sorted keys enabled
ussaama Oct 16, 2025
20c5bad
- rules updated
ussaama Oct 16, 2025
b9aa401
- ignore files node_modules, dist, package.json, pnpm-lock.yaml files
ussaama Oct 16, 2025
c507743
Merge remote-tracking branch 'origin/main' into implement-biome-rules
ussaama Oct 16, 2025
cee8e02
- fixed 163 files for biome
ussaama Oct 17, 2025
5f7c81b
- all other files linted and fixed
ussaama Oct 17, 2025
3e89182
- fixed remaining biome errors
ussaama Oct 17, 2025
f78de41
- minor error fix
ussaama Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions echo/frontend/.eslintrc
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions echo/frontend/.prettierrc
View file
Open in desktop

This file was deleted.

74 changes: 56 additions & 18 deletions echo/frontend/biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,75 @@
{
"$schema": "https://biomejs.dev/schemas/2.2.4/schema.json",
"vcs": {
"enabled": false,
"clientKind": "git",
"useIgnoreFile": false
"assist": {
"actions": {
"source": {
"organizeImports": "on",
"useSortedKeys": "on"
}
},
"enabled": true
},
"css": {
"linter": {
"enabled": true
}
},
"files": {
"ignoreUnknown": false
"includes": [
"**/*",
"!**/dist",
"!**/node_modules",
"!**/package-lock.json",
"!**/package.json",
"!**/locales"
]
},
"formatter": {
"enabled": true,
"indentStyle": "tab"
},
"javascript": {
"formatter": {
"quoteStyle": "double"
}
},
"json": {
"formatter": {
"indentStyle": "tab"
}
},
"linter": {
"enabled": true,
"rules": {
"recommended": true,
"correctness": {
"noUndeclaredDependencies": "error",
"noUnusedVariables": "error",
"useUniqueElementIds": "off"
},
"style": {
"noInferrableTypes": "error",
"noParameterAssign": "error",
"noUnusedTemplateLiteral": "error",
"useArrayLiterals": "error",
"useAsConstAssertion": "error",
"useCollapsedElseIf": "error",
"useConst": "error",
"useDefaultParameterLast": "error",
"useEnumInitializers": "error",
"useNumberNamespace": "error",
"useSelfClosingElements": "error",
"useSingleVarDeclarator": "error",
"useTemplate": "error"
},
"suspicious": {
"noAlert": "warn",
"noCatchAssign": "error",
"noVar": "error"
}
}
},
"javascript": {
"formatter": {
"quoteStyle": "double"
}
},
"assist": {
"vcs": {
"clientKind": "git",
"enabled": true,
"actions": {
"source": {
"organizeImports": "on"
}
}
"useIgnoreFile": true
}
}
22 changes: 11 additions & 11 deletions echo/frontend/lingui.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import type { LinguiConfig } from "@lingui/conf";

const config: LinguiConfig = {
locales: ["en-US", "nl-NL", "de-DE", "fr-FR", "es-ES"],
sourceLocale: "en-US",
fallbackLocales: {
default: "en-US",
},
catalogs: [
{
path: "<rootDir>/src/locales/{locale}",
include: ["src"],
},
],
catalogs: [
{
include: ["src"],
path: "<rootDir>/src/locales/{locale}",
},
],
fallbackLocales: {
default: "en-US",
},
locales: ["en-US", "nl-NL", "de-DE", "fr-FR", "es-ES"],
sourceLocale: "en-US",
};

export default config;
20 changes: 8 additions & 12 deletions echo/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,14 @@
"participant:dev": "VITE_DISABLE_SENTRY=1 VITE_USE_PARTICIPANT_ROUTER=1 vite --port 5174 --host 0.0.0.0",
"messages:extract": "lingui extract",
"messages:compile": "lingui compile --typescript",
"build": "tsc && vite build",
"participant:build": "tsc && VITE_API_BASE_URL=http://localhost:8000/api VITE_USE_PARTICIPANT_ROUTER=1 vite build",
"format": "prettier --write .",
"lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"build": "biome check . && tsc && vite build",
"participant:build": "biome check . && tsc && VITE_API_BASE_URL=http://localhost:8000/api VITE_USE_PARTICIPANT_ROUTER=1 vite build",
"format": "biome format --write .",
"format:check": "biome format .",
"lint": "biome lint .",
"lint:fix": "biome lint --write .",
"check": "biome check .",
"fix": "biome check --write .",
"preview": "vite preview"
},
"dependencies": {
Expand Down Expand Up @@ -59,7 +63,6 @@
"next-themes": "^0.4.6",
"notifications\n": "link:@mantine/notifications\n",
"plausible-tracker": "^0.3.9",
"prettier-plugin-tailwindcss": "^0.6.14",
"re-resizable": "^6.11.2",
"react": "^19.0.0",
"react-dom": "^19.0.0",
Expand Down Expand Up @@ -96,20 +99,13 @@
"@types/react": "^19.0.12",
"@types/react-dom": "^19.0.4",
"@types/showdown": "^2.0.6",
"@typescript-eslint/eslint-plugin": "^8.28.0",
"@typescript-eslint/parser": "^8.28.0",
"@vitejs/plugin-react": "^4.7.0",
"autoprefixer": "^10.4.21",
"babel-plugin-react-compiler": "19.0.0-beta-37ed2a7-20241206",
"debug": "^4.4.0",
"eslint": "~9.16.0",
"eslint-plugin-react-compiler": "19.0.0-beta-37ed2a7-20241206",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-react-refresh": "^0.4.19",
"postcss": "^8.5.3",
"postcss-preset-mantine": "^1.17.0",
"postcss-simple-vars": "^7.0.1",
"prettier": "^3.5.3",
"tailwindcss": "^3.4.17",
"typescript": "^5.8.2",
"vite": "^6.3.5"
Expand Down
Loading
Loading