Skip to content

ECHO-513 dutch spelling mistake fixed#345

Merged
ussaama merged 1 commit intomainfrom
dutch-spelling-mistake
Oct 21, 2025
Merged

ECHO-513 dutch spelling mistake fixed#345
ussaama merged 1 commit intomainfrom
dutch-spelling-mistake

Conversation

@ussaama
Copy link
Copy Markdown
Contributor

@ussaama ussaama commented Oct 21, 2025

Summary by CodeRabbit

  • Chores
    • Updated translations across multiple supported languages (German, English, Spanish, French, Dutch)
    • Cleaned up and reorganized localization entries to improve translation maintenance
    • Refined announcement-related notification strings and updated miscellaneous UI text for consistency

@linear
Copy link
Copy Markdown

linear bot commented Oct 21, 2025

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 21, 2025

Walkthrough

This PR updates locale translation files across five languages to deprecate unused announcement-related error messages, adjust source line reference mappings, and correct a Dutch translation ("Let us know!" → "Laat het ons weten!"). No functional logic changes; purely translation infrastructure updates.

Changes

Cohort / File(s) Summary
Localization deprecations and line reference updates
echo/frontend/src/locales/de-DE.po, echo/frontend/src/locales/en-US.po, echo/frontend/src/locales/es-ES.po, echo/frontend/src/locales/fr-FR.po, echo/frontend/src/locales/nl-NL.po
Marked announcement error entries as obsolete (#~ prefix): "Failed to get the latest announcement", "Failed to get unread announcements count", "Failed to load audio or the audio is not available". Updated source line references for "Failed to mark all announcements as read" and "Failed to mark announcement as read" across all locales.
Dutch translation correction
echo/frontend/src/locales/nl-NL.po
Updated "Let us know!" translation to "Laat het ons weten!" to correct spelling (ECHO-513).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Homogeneous changes across translation files following consistent deprecation and line-reference update patterns. Verification requires confirming deprecated entries are genuinely unused and the Dutch translation fix is semantically correct.

Possibly related PRs

Suggested labels

improvement


LGTM. Clean translation cleanup with proper deprecation patterns and a solid Dutch spelling fix. The consistency across all locale files tells me this was coordinated well. Ship it. 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning While the nl-NL.po file correctly addresses ECHO-513's objective, the PR introduces significant additional changes across four other locale files (de-DE.po, en-US.po, es-ES.po, fr-FR.po) that deprecate announcement-related translation entries and adjust source line references. These deprecations and refactoring changes across multiple locales appear unrelated to the stated objective of fixing a single Dutch spelling mistake, representing scope creep beyond what ECHO-513 specifies. The PR bundles what should be a focused Dutch spelling fix with broader locale maintenance work. Separate the Dutch spelling fix changes into their own PR to keep ECHO-513 focused. Move the announcement-related deprecations and line reference adjustments across all locale files into a distinct PR with its own issue tracking, or clarify if these changes are required dependencies for this fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "ECHO-513 dutch spelling mistake fixed" is concise and directly references the linked issue while clearly indicating the primary change. It immediately communicates that this addresses a Dutch spelling fix tied to ECHO-513, which aligns with the actual objective of updating the Dutch translation to "Laat het ons weten!" in the locale files. The title is specific enough for a teammate scanning history to understand the core intent.
Linked Issues Check ✅ Passed The PR successfully addresses the primary objective from ECHO-513: the nl-NL.po file shows the translation update for "Let us know!" changed to "Laat het ons weten!", which directly satisfies the requirement to fix the Dutch spelling text in the 3-dots menu for templates. The core coding requirement from the linked issue is met by this locale file modification.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dutch-spelling-mistake

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4930851 and d2e458a.

📒 Files selected for processing (5)
  • echo/frontend/src/locales/de-DE.po (1 hunks)
  • echo/frontend/src/locales/en-US.po (1 hunks)
  • echo/frontend/src/locales/es-ES.po (1 hunks)
  • echo/frontend/src/locales/fr-FR.po (1 hunks)
  • echo/frontend/src/locales/nl-NL.po (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ussaama
PR: Dembrane/echo#180
File: echo/frontend/src/locales/es-ES.ts:1-1
Timestamp: 2025-06-06T05:43:44.935Z
Learning: When users indicate they have already addressed translation issues in locale files, verify the current state before assuming the issue persists. Translation files are often updated in bulk and previously flagged English text may have been properly localized.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: ci-check-server
🔇 Additional comments (6)
echo/frontend/src/locales/es-ES.po (1)

1119-1126: Hook location remap checks out. Lingui refs now point at the split hook offsets and the live strings stay intact. LGTM.

echo/frontend/src/locales/fr-FR.po (1)

1119-1126: Reference sync is solid. The FR catalog mirrors the hook shuffle cleanly—nothing broken, everything crisp. LGTM.

echo/frontend/src/locales/nl-NL.po (1)

1583-1586: Dutch copy fix looks clean

Matches the ECHO-513 copy requirement. LGTM.

echo/frontend/src/locales/en-US.po (3)

1467-1469: Scope mismatch: Dutch translation fix not visible in EN-US locale file.

The PR objectives state this fixes Dutch spelling ("Laat het ons weten!"), but the provided file is the English locale. The actual Dutch translation changes should be in a separate Dutch locale file (e.g., nl-NL.po or nl.po). Verify that the Dutch locale file updates are included in this PR.


1139-1150: Announcement-related translations deprecated—verify this is intentional.

Three announcement error messages are now marked as deprecated (#~):

  • "Failed to get the latest announcement"
  • "Failed to get unread announcements count"
  • "Failed to load audio or the audio is not available"

Confirm these messages are no longer referenced anywhere in the codebase and that deprecating them won't break existing features.


1152-1160: Source line references shifted for announcement messages.

The two announcement error messages that remain active now reference different source locations:

  • "Failed to mark all announcements as read": moved from single location to hooks/index.ts:343 and hooks/index.ts:356
  • "Failed to mark announcement as read": moved to hooks/index.ts:185 and hooks/index.ts:204

This suggests refactoring or code reorganization. Verify these new references are accurate and the hooks have been updated accordingly.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ussaama ussaama requested a review from spashii October 21, 2025 08:10
@ussaama ussaama added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit cde51c0 Oct 21, 2025
11 checks passed
@ussaama ussaama deleted the dutch-spelling-mistake branch October 21, 2025 08:15
spashii pushed a commit that referenced this pull request Nov 18, 2025
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
- Updated translations across multiple supported languages (German,
English, Spanish, French, Dutch)
- Cleaned up and reorganized localization entries to improve translation
maintenance
- Refined announcement-related notification strings and updated
miscellaneous UI text for consistency

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants