ECHO-538 (build) ignore lint errors during vercel deploy

[spashii]

Summary by CodeRabbit

• Chores
  • Reorganized CI workflow by separating lint and build steps into distinct stages for improved visibility
  • Simplified build scripts by removing pre-check validation from the build process

[linear]

ECHO-538 Fix vercel frontends build

[coderabbitai]

Walkthrough

Splits the frontend CI workflow into separate lint and build steps, and removes biome pre-checks from the build scripts in package.json, simplifying the build process from "biome check . && tsc && vite build" to "tsc && vite build". Also removes the participant:build script variant.

Changes

Cohort / File(s)	Change Summary
CI Workflow Restructuring .github/workflows/ci.yml	Splits combined "Lint and build" step into two discrete steps: explicit "Lint" step and "Build" step for improved workflow visibility and debugging granularity.
Build Script Simplification echo/frontend/package.json	Removes biome check pre-processor from build pipeline ("biome check . && tsc && vite build" → "tsc && vite build"); removes participant:build script variant that included environment variable configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Config-level changes across two files with straightforward, homogeneous modifications—no logic density or cross-cutting concerns to reason through.

Possibly related PRs

• Build/ci #73: Directly modifies .github/workflows/ci.yml for frontend CI job setup; shares the same workflow restructuring domain and build process optimization focus.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "ECHO-538 (build) ignore lint errors during vercel deploy" precisely captures the primary change in the pull request. The modifications directly reflect the stated objective: removing biome-based pre-checks (linting) from the build scripts and restructuring CI steps to allow builds to proceed without blocking on lint errors. The title is concise, specific, and clearly communicates the core intent to someone reviewing the Git history.
Linked Issues Check	✅ Passed	The linked issue ECHO-538 provides minimal description beyond "Fix vercel frontends build," making complete requirement validation challenging. However, the code changes align with addressing Vercel build failures by removing lint checks from the build pipeline, which directly supports the objective of fixing frontend builds. The removal of biome checks and the participant:build script simplification are consistent with de-blocking Vercel deployments from lint-related failures, though more granular issue requirements would strengthen full compliance verification.
Out of Scope Changes Check	✅ Passed	All code changes are directly aligned with the Vercel build fix objective. The workflow refactoring (splitting CI into separate Lint and Build steps), removal of biome checks from build scripts, and elimination of the participant:build script are all intentional modifications to support the deployment fix. These changes represent coherent scope focused on unblocking the build process and do not introduce unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-fe-build-vercel

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cde51c0 and eab9a6f.

📒 Files selected for processing (2)

• .github/workflows/ci.yml (1 hunks)
• echo/frontend/package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ci-check-server

🔇 Additional comments (3)

.github/workflows/ci.yml (1)

95-99: Verify lint error handling aligns with PR objective.

The PR title mentions "ignore lint errors during vercel deploy," but the lint step here (line 95-96) doesn't have continue-on-error: true. This means lint failures will still block the build step from running, and the overall ci-check-frontend job will fail, preventing ci-build-and-push-servers from executing.

If the goal is to allow builds despite lint failures, the lint step needs continue-on-error: true:

      - name: Lint 
+       continue-on-error: true
        run: pnpm run lint

Alternatively, if lint should remain blocking, the PR objective might be misleading or the actual error-ignoring happens in the package.json changes (e.g., the build script itself).

Can you clarify whether lint failures should block deployments or not? If they shouldn't, apply the continue-on-error: true flag above.

echo/frontend/package.json (2)

11-11: LGTM—build script cleanup looks solid.

Removing biome check from the build pipeline and deferring linting to separate CI steps is the right call. Keeps the build lean and lets linting fail fast as its own gate.

---

6-19: All concerns verified—participant:build removal is safe to ship.

✅ Zero references to participant:build across entire codebase (rg confirmed)
✅ No CI workflows invoke participant:build (GitHub Actions, Vercel deploys all use generic pnpm run build)
✅ No documentation or runbooks reference the removed script
✅ participant:dev on line 8 remains intact with VITE_USE_PARTICIPANT_ROUTER=1

The removal is a clean break with no downstream impact.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ussaama]

@spashii is this not needed? "&& VITE_API_BASE_URL=http://localhost:8000/api VITE_USE_PARTICIPANT_ROUTER=1" ?

[spashii]

we don't use the participant:build anywhere