Skip to content

- artefacts loading title fix that shows on slow networks #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spashii merged 1 commit into from
Nov 22, 2025
Merged

- artefacts loading title fix that shows on slow networks #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 37 additions & 38 deletions echo/frontend/src/components/conversation/VerifiedArtefactsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,17 @@ export const VerifiedArtefactsSection = ({
queryKey: ["verify", "conversation_artifacts", conversationId],
});

if (isLoading) {
return (
<Stack gap="sm">
<Skeleton height={60} width="50%" radius="md" />
<Skeleton height={60} width="50%" radius="md" />
</Stack>
);
}

// Don't show the section if there are no artefacts
if (!isLoading && (!artefacts || artefacts.length === 0)) {
if (!artefacts || artefacts.length === 0) {
return null;
}

Expand All @@ -60,44 +69,34 @@ export const VerifiedArtefactsSection = ({
</ActionIcon>
</Group>

{isLoading && (
<Stack gap="sm">
<Skeleton height={60} width="50%" radius="md" />
<Skeleton height={60} width="50%" radius="md" />
</Stack>
)}

{!isLoading && artefacts && artefacts.length > 0 && (
<Accordion variant="unstyled" radius="md">
{artefacts.map((artefact) => {
const formattedDate = formatArtefactTime(artefact.approved_at);
<Accordion variant="unstyled" radius="md">
{artefacts.map((artefact) => {
const formattedDate = formatArtefactTime(artefact.approved_at);

return (
<Accordion.Item key={artefact.id} value={artefact.id}>
<Accordion.Control>
<Group gap="sm" wrap="nowrap">
<Stack gap={2}>
{/* <Text fw={500}>{artefact.title ?? artefact.key}</Text> */}
<Text fw={500}>{artefact.key || ""}</Text>
{formattedDate && (
<Text size="xs" c="dimmed">
<Trans id="conversation.verified.approved">
Approved
</Trans>{" "}
{formattedDate}
</Text>
)}
</Stack>
</Group>
</Accordion.Control>
<Accordion.Panel>
<Markdown content={artefact.content ?? ""} />
</Accordion.Panel>
</Accordion.Item>
);
})}
</Accordion>
)}
return (
<Accordion.Item key={artefact.id} value={artefact.id}>
<Accordion.Control>
<Group gap="sm" wrap="nowrap">
<Stack gap={2}>
<Text fw={500}>{artefact.key || ""}</Text>
{formattedDate && (
<Text size="xs" c="dimmed">
<Trans id="conversation.verified.approved">
Approved
</Trans>{" "}
{formattedDate}
</Text>
)}
</Stack>
</Group>
</Accordion.Control>
<Accordion.Panel>
<Markdown content={artefact.content ?? ""} />
</Accordion.Panel>
</Accordion.Item>
);
})}
</Accordion>
</Stack>
);
};
Loading