Conversation
- change "Neem even de tijd om een resultaat te creëren dat je bijdrage concreet maakt" to "Kijk of de uitkomst klopt, en pas aan waar nodig" in "nl.po" and "nl.ts" files
Contributor
WalkthroughUpdated Dutch localization file with terminology shifts, replacing "Verifiëren" with "Controleren" across verify-related UI strings including buttons, labels, modals, and instructional copy. Some content phrasing was adjusted alongside terminology changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@echo/frontend/src/locales/nl-NL.po`:
- Line 4108: Update the Dutch informal pronouns in the translated strings:
replace formal "uw" with informal "je/jij" in the msgstr entries shown (e.g.,
the string "Wacht aub terwijl we uw e-mailadres controleren." and the other
occurrence noted at lines 5549), ensuring punctuation/spacing stays correct and
consistent with existing locale style; keep the meaning unchanged and run a
quick gettext/lint check to confirm no syntax issues in the .po file.
- Line 2134: The strings still use "geverifieerd(e)" and must be migrated to the
new Verify→Controleren terminology: update occurrences of "geverifieerd" /
"geverifieerde" in the msgstr entries (e.g., the shown msgstr and the other
occurrences flagged) to the appropriate Dutch "gecontroleerd" / "gecontroleerde"
or rephrase to "resultaten die zijn gecontroleerd" so grammar remains correct;
ensure all three changed strings (the shown msgstr and the two other instances
mentioned) are updated consistently to use "controleren"/"gecontroleerd"
terminology.
- Line 2615: The Dutch translation string in the msgstr (the webhook secret
description) contains a missing space in "handtekeningvereist"; update the
msgstr text so it reads "...Als je ontvangende service een handtekening
vereist." (i.e., insert a space between "handtekening" and "vereist") ensuring
punctuation and capitalization remain consistent with the original sentence.
- Line 6208: The msgstr for the "Verify Topics" translation currently contains a
mixed-language typo (msgstr "Controleren Themen"); update this translation entry
so the Dutch is consistent — for example replace msgstr "Controleren Themen"
with a proper Dutch phrase such as "Controleren onderwerpen" or "Onderwerpen
controleren" in the same translation unit (the msgstr for the Verify Topics
label).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 72db779d-adba-4697-840a-e81930a297e1
📒 Files selected for processing (2)
echo/frontend/src/locales/nl-NL.poecho/frontend/src/locales/nl-NL.ts
| #: src/components/project/ProjectPortalEditor.tsx:1006 | ||
| msgid "dashboard.dembrane.feature.verify.description" | ||
| msgstr "Schakel deze functie in om deelnemers \"resultaten\" van hun inzendingen te laten verifiëren en goedkeuren. Dit helpt om belangrijke ideeën, zorgen of samenvattingen concreet te maken. Na het gesprek kun je filteren op discussies met geverifieerde resultaten en deze bekijken in het overzicht." | ||
| msgstr "Schakel deze functie in om deelnemers \"resultaten\" van hun inzendingen te laten controleren en goedkeuren. Dit helpt om belangrijke ideeën, zorgen of samenvattingen concreet te maken. Na het gesprek kun je filteren op discussies met geverifieerde resultaten en deze bekijken in het overzicht." |
Contributor
There was a problem hiding this comment.
Finish the Verify→Controleren terminology migration in changed strings
A few updated lines still contain “geverifieerd(e)”, which conflicts with the new naming and creates mixed terminology in the same flow.
Suggested fix
-msgstr "Schakel deze functie in om deelnemers \"resultaten\" van hun inzendingen te laten controleren en goedkeuren. Dit helpt om belangrijke ideeën, zorgen of samenvattingen concreet te maken. Na het gesprek kun je filteren op discussies met geverifieerde resultaten en deze bekijken in het overzicht."
+msgstr "Schakel deze functie in om deelnemers \"resultaten\" van hun inzendingen te laten controleren en goedkeuren. Dit helpt om belangrijke ideeën, zorgen of samenvattingen concreet te maken. Na het gesprek kun je filteren op discussies met gecontroleerde resultaten en deze bekijken in het overzicht."
-msgstr "Wanneer je het gesprek afmaakt, worden deelnemers die nog niet hebben geverifieerd gevraagd om te controleren of over te slaan"
+msgstr "Wanneer je het gesprek afmaakt, worden deelnemers die nog niet hebben gecontroleerd gevraagd om te controleren of over te slaan"
-msgstr "Je hebt nog geen resultaten geverifieerd. Wil je controleren voordat je afsluit?"
+msgstr "Je hebt nog geen resultaten gecontroleerd. Wil je controleren voordat je afsluit?"Also applies to: 6457-6457, 6536-6536
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@echo/frontend/src/locales/nl-NL.po` at line 2134, The strings still use
"geverifieerd(e)" and must be migrated to the new Verify→Controleren
terminology: update occurrences of "geverifieerd" / "geverifieerde" in the
msgstr entries (e.g., the shown msgstr and the other occurrences flagged) to the
appropriate Dutch "gecontroleerd" / "gecontroleerde" or rephrase to "resultaten
die zijn gecontroleerd" so grammar remains correct; ensure all three changed
strings (the shown msgstr and the two other instances mentioned) are updated
consistently to use "controleren"/"gecontroleerd" terminology.
| #: src/components/project/webhooks/WebhookSettingsCard.tsx:454 | ||
| msgid "For advanced users: A secret key to verify webhook authenticity. Only needed if your receiving service requires signature verification." | ||
| msgstr "Voor geavanceerde gebruikers: Een geheime sleutel om de authenticiteit van de webhook te verifiëren. Alleen nodig als je ontvangende service een handtekeningvereist." | ||
| msgstr "Voor geavanceerde gebruikers: Een geheime sleutel om de authenticiteit van de webhook te controleren. Alleen nodig als je ontvangende service een handtekeningvereist." |
Contributor
There was a problem hiding this comment.
Fix spacing typo in webhook secret description
handtekeningvereist is missing a space.
Suggested fix
-msgstr "Voor geavanceerde gebruikers: Een geheime sleutel om de authenticiteit van de webhook te controleren. Alleen nodig als je ontvangende service een handtekeningvereist."
+msgstr "Voor geavanceerde gebruikers: Een geheime sleutel om de authenticiteit van de webhook te controleren. Alleen nodig als je ontvangende service een handtekening vereist."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| msgstr "Voor geavanceerde gebruikers: Een geheime sleutel om de authenticiteit van de webhook te controleren. Alleen nodig als je ontvangende service een handtekeningvereist." | |
| msgstr "Voor geavanceerde gebruikers: Een geheime sleutel om de authenticiteit van de webhook te controleren. Alleen nodig als je ontvangende service een handtekening vereist." |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@echo/frontend/src/locales/nl-NL.po` at line 2615, The Dutch translation
string in the msgstr (the webhook secret description) contains a missing space
in "handtekeningvereist"; update the msgstr text so it reads "...Als je
ontvangende service een handtekening vereist." (i.e., insert a space between
"handtekening" and "vereist") ensuring punctuation and capitalization remain
consistent with the original sentence.
| #: src/routes/auth/VerifyEmail.tsx:46 | ||
| msgid "Please wait while we verify your email address." | ||
| msgstr "Wacht aub terwijl we uw e-mailadres verifiëren." | ||
| msgstr "Wacht aub terwijl we uw e-mailadres controleren." |
Contributor
There was a problem hiding this comment.
Use informal Dutch pronouns in user-facing copy
These updated strings still use formal “uw”. Switch to “je/jij” for consistency with the Dutch locale standard in this repo.
Suggested fix
-msgstr "Wacht aub terwijl we uw e-mailadres controleren."
+msgstr "Wacht aub terwijl we je e-mailadres controleren."
-msgstr "Er is een fout opgetreden bij het controleren van uw e-mail. Probeer het alstublieft opnieuw."
+msgstr "Er is een fout opgetreden bij het controleren van je e-mail. Probeer het alstublieft opnieuw."As per coding guidelines "Use Dutch localization 'je/jij' not 'u/uw' in user-facing strings".
Also applies to: 5549-5549
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@echo/frontend/src/locales/nl-NL.po` at line 4108, Update the Dutch informal
pronouns in the translated strings: replace formal "uw" with informal "je/jij"
in the msgstr entries shown (e.g., the string "Wacht aub terwijl we uw
e-mailadres controleren." and the other occurrence noted at lines 5549),
ensuring punctuation/spacing stays correct and consistent with existing locale
style; keep the meaning unchanged and run a quick gettext/lint check to confirm
no syntax issues in the .po file.
| #: src/components/project/ProjectPortalEditor.tsx:1047 | ||
| msgid "Verify Topics" | ||
| msgstr "Verifiëren Themen" | ||
| msgstr "Controleren Themen" |
Contributor
There was a problem hiding this comment.
Fix mixed-language typo in the Verify Topics label
"Controleren Themen" mixes Dutch and German. This will look broken in UI.
Suggested fix
-msgstr "Controleren Themen"
+msgstr "Controleonderwerpen"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| msgstr "Controleren Themen" | |
| msgstr "Controleonderwerpen" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@echo/frontend/src/locales/nl-NL.po` at line 6208, The msgstr for the "Verify
Topics" translation currently contains a mixed-language typo (msgstr
"Controleren Themen"); update this translation entry so the Dutch is consistent
— for example replace msgstr "Controleren Themen" with a proper Dutch phrase
such as "Controleren onderwerpen" or "Onderwerpen controleren" in the same
translation unit (the msgstr for the Verify Topics label).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit