Update Node.js version to 22 and modify deployment workflows#74
Conversation
…uction environment in Vercel configurations
WalkthroughThe changes update several GitHub Actions workflows. For the development deployments, the Node.js version is bumped from 18 to 22. The production workflows for both Vercel dashboard and portal now trigger on version tag pushes rather than on main branch pushes, and they update environment settings from staging to production. Additionally, the GitOps backend deployment workflow has been restructured with renamed jobs and added steps to extract tag information, update image tags using regex, and include commit hashes in commit messages. Changes
Sequence Diagram(s)sequenceDiagram
participant T as Tag Push Trigger
participant J as prod-deploy-gitops-backends Job
participant R as Repository Checkout
participant TI as Tag Information Extractor
participant G as GitOps Repository Checkout
participant U as Image Tag Updater
participant C as Commit & Push
T->>J: Initiate job on tag push
J->>R: Checkout repository with tag history
J->>TI: Extract tag name and commit hash
J->>G: Checkout GitOps repository in subdirectory
J->>U: Update global.imageTag in YAML using tag info
J->>C: Commit changes including commit hash and push updates
Possibly related PRs
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
.github/workflows/dev-deploy-vercel-portal.yml (1)
14-15: Upgrade Your Checkout Action
The Checkout step is usingactions/checkout@v3. Per static analysis hints, you might consider updating it to a more recent version if you run into runner issues.🧰 Tools
🪛 actionlint (1.7.4)
15-15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/dev-deploy-vercel-dashboard.yml (1)
14-15: Heads Up on Checkout Version
The Checkout step usesactions/checkout@v3. It could be worth double-checking if a later version might smooth out any runner hiccups.🧰 Tools
🪛 actionlint (1.7.4)
15-15: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/prod-deploy-vercel-portal.yml (1)
13-15: Review the Checkout Step
Just as in the other workflows, the Checkout block is usingactions/checkout@v3. If your environment shows any runner issues, consider checking for a newer version.🧰 Tools
🪛 actionlint (1.7.4)
14-14: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/prod-deploy-vercel-dashboard.yml (1)
15-16: Double-Check the Checkout Action
The Checkout step here is still onactions/checkout@v3. Consider verifying if a newer version might offer improved reliability.🧰 Tools
🪛 actionlint (1.7.4)
16-16: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/prod-deploy-gitops-backends.yaml (2)
11-16: Solid Tag-Aware Checkout
The repository checkout that fetches all history and tags is robust. Again, a nudge to consider updatingactions/checkout@v3if you encounter any issues.🧰 Tools
🪛 actionlint (1.7.4)
12-12: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
26-33: GitOps Repository Checkout Looks Good
The separate checkout for the GitOps repository is clear and effective. A quick note: if you update other checkout actions, be sure to keep this one in sync.🧰 Tools
🪛 actionlint (1.7.4)
27-27: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/dev-deploy-vercel-dashboard.yml(1 hunks).github/workflows/dev-deploy-vercel-portal.yml(1 hunks).github/workflows/prod-deploy-gitops-backends.yaml(1 hunks).github/workflows/prod-deploy-vercel-dashboard.yml(3 hunks).github/workflows/prod-deploy-vercel-portal.yml(3 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/prod-deploy-gitops-backends.yaml
12-12: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
27-27: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (9)
.github/workflows/dev-deploy-vercel-portal.yml (1)
17-20: Nice Node.js Bump!
The upgrade to Node.js version 22 is spot on and fully aligns with the PR objectives. LGTM.🧰 Tools
🪛 actionlint (1.7.4)
18-18: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/dev-deploy-vercel-dashboard.yml (1)
18-21: Awesome Node.js Upgrade!
Bumping the Node.js version to 22 here is consistent and exactly what we need. LGTM.🧰 Tools
🪛 actionlint (1.7.4)
18-18: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/prod-deploy-vercel-portal.yml (2)
5-7: Production Trigger Set-Up is Solid!
Switching the trigger to tag pushes (matching"v*.*.*") is exactly what a production workflow needs. LGTM.
16-19: Node.js Version Confirmed
The update to Node.js version 22 is executed flawlessly.🧰 Tools
🪛 actionlint (1.7.4)
17-17: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/prod-deploy-vercel-dashboard.yml (2)
7-9: Trigger Update is Spot On!
Using tag-based triggers for production deployment is exactly the kind of precision we expect. LGTM.
18-21: Node.js Version is Nicely Upgraded
Updating to Node.js 22 across the board ensures consistency in our deployment environments. LGTM.🧰 Tools
🪛 actionlint (1.7.4)
19-19: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/prod-deploy-gitops-backends.yaml (3)
17-25: Clean and Concise Tag Extraction
Extracting the tag information and commit hash is well implemented, ensuring top-notch traceability. LGTM.
34-42: Regex Update is On Point
The sed command for updatingglobal.imageTaginvalues-prod.yamlis sharp and should capably handle the intended pattern. LGTM.
43-50: Commit & Push Step—Clean and Informative
Including both the tag name and commit hash in the commit message is a slick move. The commit and push step is well structured. LGTM.
Update Node.js version to 22 and modify deployment workflows for production environment in Vercel configurations
1 participant
Summary by CodeRabbit