Cast full-number float to int, just as the JS vt-pbf does #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysMoskalenko
approved these changes
Oct 28, 2025
Owner
DenysMoskalenko
left a comment
DenysMoskalenko
left a comment
There was a problem hiding this comment.
Great catch—thanks for the fix! I’m happy to merge this. Could you please resolve the remaining conflicts? Once that’s done, I’ll merge it right away. If you’d like a hand with the conflict resolution, just let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #23 (and discussion in PR #22)