fixed trigger.dev error, fixed upload azure dependency error#205
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a36d5aaa70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Job runner backend: "inngest" (default) or "trigger-dev" | ||
| JOB_RUNNER: z.enum(["inngest", "trigger-dev"]).default("inngest"), | ||
| // Job runner backend | ||
| JOB_RUNNER: z.enum(["inngest"]).default("inngest"), |
There was a problem hiding this comment.
Restricting JOB_RUNNER to z.enum(["inngest"]) causes the app to fail fast at env parsing time whenever an existing deployment still has JOB_RUNNER=trigger-dev configured, so startup breaks before getJobRunner() can apply its fallback-to-inngest logic. This is a production-impacting regression for previously valid configs and should be handled with a compatibility path (or an explicit migration guard) instead of a hard parse failure.
Useful? React with 👍 / 👎.
| let rows: ANNRow[] = results.map(r => ({ | ||
| id: r.id, | ||
| content: r.content, | ||
| page: r.page ?? 0, |
There was a problem hiding this comment.
Mapping page with r.page ?? 0 turns unknown page metadata into an invalid concrete page number, which can surface as Page 0 in responses and degrades citation/recommendation quality for rows where page_number is null (the schema allows null). Previously this value was preserved as null/unknown, so this introduces inaccurate pagination metadata in ANN results.
Useful? React with 👍 / 👎.
1 participant
No description provided.