Feature/front page improvement#234
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ec2b76bb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const [userInfo] = await db | ||
| .select({ companyId: users.companyId }) | ||
| .from(users) | ||
| .where(eq(users.userId, userId)); |
There was a problem hiding this comment.
Restrict onboarding updates to employer/owner roles
This handler updates company profile fields after checking only that a Clerk session exists, but it never verifies users.role before writing to company, unlike src/app/api/updateCompany/route.ts which explicitly gates to employer/owner. As written, any authenticated employee in the same company can call POST /api/company/onboarding and overwrite shared company description/industry, which is an authorization regression for mutable company settings.
Useful? React with 👍 / 👎.
| text: "Every upload enriches your company profile and powers AI features", | ||
| iconWrap: styles.quickStartIconPurple, | ||
| iconColor: styles.quickStartIconColorPurple, | ||
| href: "/employer/documents?view=upload", |
There was a problem hiding this comment.
Make onboarding quick-start links open the intended tab
These quick-start URLs add a ?view=... query, but the documents shell does not read view at all (it initializes viewMode to a fixed default and only parses docId), so users are always dropped on the default screen instead of Upload/Marketing/Metadata. This breaks the new onboarding navigation flow and similarly affects other ?view= links such as the metadata panel’s Settings edit link.
Useful? React with 👍 / 👎.
Improved frontend design and login page design