Form to Contribute Data #1669
Open
Form to Contribute Data #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnets
previously requested changes
Nov 10, 2025
Contributor
fnets
left a comment
fnets
left a comment
There was a problem hiding this comment.
There's a couple of things that you'll want to add before exposing a form to unauthenticated users for security reasons.
fnets
reviewed
Nov 10, 2025
client/modules/reconportal/src/ReconSidePanel/ContributeDataModal.tsx
Outdated
Show resolved
Hide resolved
fnets
requested review from
cs-jansen and
wesleyboar
and removed request for
cs-jansen and
wesleyboar
fnets
reviewed
Dec 8, 2025
fnets
approved these changes
Dec 9, 2025
Contributor
fnets
left a comment
fnets
left a comment
There was a problem hiding this comment.
Everything LGTM! Some geospatial folks should review too, but great work.
nathanfranklin
requested changes
Dec 15, 2025
Member
nathanfranklin
left a comment
nathanfranklin
left a comment
There was a problem hiding this comment.
Looking good 👍
Left a comment on form library usage. Waiting to test locally until we resolve the reCAPTCHA dev issues being discussed in Slack. happy to review on code alone if needed.
| @@ -0,0 +1,287 @@ | |||
| import React, { useState } from 'react'; | |||
| import { Button, Form, Input, Modal, Typography, notification } from 'antd'; | |||
| import { Formik, Form as FormikForm } from 'formik'; | |||
Member
There was a problem hiding this comment.
For consistency with the rest of the codebase, should we use Antd Form + Zod instead of Formik + Yup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Modal added "Email us to Contribute your Data" under Recon Portal
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes:
Need to add security