Skip to content

packaging: fix build with lowdown 2.0.4#284

Merged
edolstra merged 1 commit into
DeterminateSystems:mainfrom
SandaruKasa:postInstall
Dec 4, 2025
Merged

packaging: fix build with lowdown 2.0.4#284
edolstra merged 1 commit into
DeterminateSystems:mainfrom
SandaruKasa:postInstall

Conversation

@SandaruKasa
Copy link
Copy Markdown

@SandaruKasa SandaruKasa commented Dec 3, 2025

After update to lowdown 2.0.4 in NixOS/nixpkgs#462187 it no longer has any postInstall defined.

Summary by CodeRabbit

  • Chores
    • Improved build system stability with enhanced handling of package installation configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 3, 2025

Walkthrough

This change adds defensive handling in the lowdown package configuration by introducing a fallback empty string when the postInstall attribute is undefined, preventing potential null reference errors.

Changes

Cohort / File(s) Summary
Dependencies configuration
packaging/dependencies.nix
Updated lowdown.postInstall override to use (prevAttrs.postInstall or "") instead of direct attribute access, ensuring safe handling when postInstall is undefined

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through nix so neat,
Where strings and nulls would dare to meet,
But now with or "" so wise and kind,
No undefined attribute shall we find! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the build compatibility with lowdown 2.0.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 100a2fd and 335cf66.

📒 Files selected for processing (1)
  • packaging/dependencies.nix (1 hunks)
🔇 Additional comments (1)
packaging/dependencies.nix (1)

55-58: Robust handling of missing postInstall on newer lowdown versions

Using (prevAttrs.postInstall or "") is the right way to keep this override working when upstream no longer defines postInstall, while preserving the previous behavior when it is present. lib.replaceStrings on an empty string is harmless, so this should fix the build without side effects.

Please confirm that nix build (or your CI job) now succeeds against the lowdown 2.0.4 nixpkgs snapshot to validate this in your target environments.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@edolstra edolstra enabled auto-merge December 4, 2025 12:10
@edolstra edolstra added this pull request to the merge queue Dec 4, 2025
Merged via the queue into DeterminateSystems:main with commit 40abd9e Dec 4, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants