BinaryCacheStore::queryPathInfoUncached(): Ensure noexcept

[edolstra]

Motivation

Make sure we don't throw an exception, since that will terminate the program.

Context

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for binary cache operations, ensuring exceptions are properly caught and handled through a more robust control flow.

[coderabbitai]

📝 Walkthrough

Walkthrough

The uncached path query logic in the binary cache store is refactored to wrap its operation in a try-catch block. Logging activity creation and nar-info file lookup are moved inside the try block, with exceptions rethrown via callback in the catch block, adding explicit exception-safety guarantees.

Changes

Cohort / File(s)	Summary
Exception-Safety Refactoring src/libstore/binary-cache-store.cc	Wrapped uncached path query logic in try-catch block; moved logging activity and nar-info lookup into try block; exceptions rethrown through callback in catch handler. No public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• cole-h

Poem

🐰 A try, a catch, a callback's grace,
Exception safety finds its place,
Where errors hop and get retold,
Through safer paths, both brave and bold!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding exception safety (noexcept guarantee) to the queryPathInfoUncached() function by wrapping logic in try-catch.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch eelcodolstra/nix-286-uncaught-exception-in-binarycachestorequerypathinfouncached

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Deployed on https://6984c0a6432ab524454c977b--determinate-nix.netlify.app