Rename binary-cache-v8.sqlite to binary-cache-detsys-v1.sqlite#390
Conversation
Upstream Nix recently renamed the cache to binary-cache-v8 to handle build traces, which collides with our binary-cache-v8 that handles provenance. So let's adopt a unique name.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe default SQLite database filename for the NarInfoDiskCacheImpl constructor is updated from "binary-cache-v8.sqlite" to "binary-cache-detsys-v1.sqlite". This single-line change alters the default path used to initialize the on-disk cache database without modifying any logic. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Motivation
Upstream Nix recently renamed cache to binary-cache-v8 to handle build traces, which collides with our binary-cache-v8 that handles provenance. So let's adopt a unique name.
Context
Summary by CodeRabbit