Skip to content

chore: cleanup SSE function names #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathannorris merged 2 commits into from
Apr 21, 2025
Merged

chore: cleanup SSE function names #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a312751
chore: cleanup SSE function names
jonathannorris Apr 21, 2025
55180f0
chore: run black formatter
jonathannorris Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions devcycle_python_sdk/managers/sse_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,35 +9,35 @@
class SSEManager:
def __init__(
self,
handlestate: Callable[[ld_eventsource.actions.Start], None],
handleerror: Callable[[ld_eventsource.actions.Fault], None],
handlemessage: Callable[[ld_eventsource.actions.Event], None],
handle_state: Callable[[ld_eventsource.actions.Start], None],
handle_error: Callable[[ld_eventsource.actions.Fault], None],
handle_message: Callable[[ld_eventsource.actions.Event], None],
):
self.client: ld_eventsource.SSEClient = None
self.url = ""
self.handlestate = handlestate
self.handleerror = handleerror
self.handlemessage = handlemessage
self.handle_state = handle_state
self.handle_error = handle_error
self.handle_message = handle_message

self.read_thread = threading.Thread(
target=self.read_events,
args=(self.handlestate, self.handleerror, self.handlemessage),
args=(self.handle_state, self.handle_error, self.handle_message),
)

def read_events(
self,
handlestate: Callable[[ld_eventsource.actions.Start], None],
handleerror: Callable[[ld_eventsource.actions.Fault], None],
handlemessage: Callable[[ld_eventsource.actions.Event], None],
handle_state: Callable[[ld_eventsource.actions.Start], None],
handle_error: Callable[[ld_eventsource.actions.Fault], None],
handle_message: Callable[[ld_eventsource.actions.Event], None],
):
self.client.start()
for event in self.client.all:
if isinstance(event, ld_eventsource.actions.Start):
handlestate(event)
handle_state(event)
elif isinstance(event, ld_eventsource.actions.Fault):
handleerror(event)
handle_error(event)
elif isinstance(event, ld_eventsource.actions.Event):
handlemessage(event)
handle_message(event)

def update(self, config: dict):
if self.use_new_config(config["sse"]):
Expand All @@ -52,7 +52,7 @@ def update(self, config: dict):
)
self.read_thread = threading.Thread(
target=self.read_events,
args=(self.handlestate, self.handleerror, self.handlemessage),
args=(self.handle_state, self.handle_error, self.handle_message),
)
self.read_thread.start()

Expand Down