Add protocol argument to browser-proxy, allowing run using https for Android devices #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… run in an Android device and fixed the test that validate the common browsers with a not existing iPhone version
…ould validate browser names'
Contributor
|
Thank you for making this PR. We'll review it. |
PavelMor25
requested review from
PavelMor25
and removed request for
PavelMor25
PavelMor25
suggested changes
Dec 21, 2023
Contributor
PavelMor25
left a comment
PavelMor25
left a comment
There was a problem hiding this comment.
Great work!
Could you please add a test to a separate file located at test/mocha/? You can use a test from the file test/mocha/testcafe-integration-test.js as a basis to demonstrate the functionality of your changes.
PavelMor25
approved these changes
Dec 28, 2023
PavelMor25
added a commit
that referenced
this pull request
Dec 28, 2023
…Android devices (#211) (#213) * Included the target protocol in the browser proxy, which is used when run in an Android device and fixed the test that validate the common browsers with a not existing iPhone version * Update the Iphone SE test case name for the browser-names-test.js 'Should validate browser names' * Removing comments from the browser-names-test.js --------- Co-authored-by: Marcelo Arraes <mlparraes@outlook.com> Co-authored-by: MarceloArraes <nf_mlopes@exactsciences.com>
PavelMor25
added a commit
that referenced
this pull request
Dec 28, 2023
* build(deps): bump sharp from 0.30.7 to 0.32.6 Bumps [sharp](https://github.com/lovell/sharp) from 0.30.7 to 0.32.6. - [Release notes](https://github.com/lovell/sharp/releases) - [Changelog](https://github.com/lovell/sharp/blob/main/docs/changelog.md) - [Commits](lovell/sharp@v0.30.7...v0.32.6) --- updated-dependencies: - dependency-name: sharp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Add protocol argument to browser-proxy, allowing run using https for Android devices (#211) (#213) * Included the target protocol in the browser proxy, which is used when run in an Android device and fixed the test that validate the common browsers with a not existing iPhone version * Update the Iphone SE test case name for the browser-names-test.js 'Should validate browser names' * Removing comments from the browser-names-test.js --------- Co-authored-by: Marcelo Arraes <mlparraes@outlook.com> Co-authored-by: MarceloArraes <nf_mlopes@exactsciences.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PavelMor25 <77216072+PavelMor25@users.noreply.github.com> Co-authored-by: Marcelo Arraes <mlparraes@outlook.com> Co-authored-by: MarceloArraes <nf_mlopes@exactsciences.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Android executions use the browser-proxy implementation which has defined as the target URL the protocol static to http. However, if I run my TestCafe tests using ssl options, I receive an error, since the proxy is always targeting to a http URL.
This PR is related to the issue #162 and add an argument with the protocol to the browser-proxy based on the target URL, so the proxy target can have the same protocol from the actual target URL.
In addition to that, I fixed the tests
Should return list of common browsers and devicesandShould validate browser names, which were validating a list of common browsers, but theiPhone SEalias used in the test is not listed in the BrowserStack API/documentation[closes #162]