Skip to content

Implemented lock for pipeline node output changes. #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DevJasperNL merged 1 commit into from
Jan 3, 2026
Merged

Implemented lock for pipeline node output changes. #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/CodeCasa.AutomationPipelines/Pipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ namespace CodeCasa.AutomationPipelines;
/// </summary>
public class Pipeline<TState> : PipelineNode<TState>, IPipeline<TState>
{
private readonly Lock _lock = new();
private readonly List<IPipelineNode<TState>> _nodes = new();
private readonly ILogger<Pipeline<TState>>? _logger;

Expand Down Expand Up @@ -136,8 +137,12 @@ public IPipeline<TState> RegisterNode(IPipelineNode<TState> node)
var destinationIndex = _nodes.Count;
previousNode.OnNewOutput.Subscribe(output =>
{
_logger?.LogTrace($"{LogPrefix}[Node {sourceIndex}] ({previousNode}) passed value [{output?.ToString() ?? "NULL"}] to [Node {destinationIndex}] ({node}).");
node.Input = output;
lock (_lock)
{
_logger?.LogTrace(
$"{LogPrefix}[Node {sourceIndex}] ({previousNode}) passed value [{output?.ToString() ?? "NULL"}] to [Node {destinationIndex}] ({node}).");
node.Input = output;
}
});

_logger?.LogTrace($"{LogPrefix}Passing [Node {sourceIndex}] ({previousNode}) value [{previousNode.Output?.ToString() ?? "NULL"}] to [Node {destinationIndex}] ({node}).");
Expand All @@ -157,8 +162,12 @@ public IPipeline<TState> RegisterNode(IPipelineNode<TState> node)
var nodeIndex = _nodes.Count - 1;
_subscription = node.OnNewOutput.Subscribe(o =>
{
_logger?.LogTrace($"{LogPrefix}[Node {nodeIndex}] ({node}) passed value [{o?.ToString() ?? "NULL"}] to pipeline output.");
SetOutputAndCallActionWhenApplicable(o);
lock (_lock)
{
_logger?.LogTrace(
$"{LogPrefix}[Node {nodeIndex}] ({node}) passed value [{o?.ToString() ?? "NULL"}] to pipeline output.");
SetOutputAndCallActionWhenApplicable(o);
}
});

var newOutput = node.Output;
Expand Down