Skip to content

Passing instantiationScope to the child configurators. #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DevJasperNL merged 1 commit into from
Feb 12, 2026
Merged

Passing instantiationScope to the child configurators. #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...utomationPipelines.Lights/Pipeline/CompositeLightTransitionPipelineConfigurator.Switch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public ILightTransitionPipelineConfigurator<TLight> AddReactiveNodeSwitch<TObser
if (instantiationScope == InstantiationScope.Shared)
{
var observable = ActivatorUtilities.CreateInstance<TObservable>(serviceProvider);
return AddReactiveNodeSwitch(observable, trueConfigure, falseConfigure);
return AddReactiveNodeSwitch(observable, trueConfigure, falseConfigure, instantiationScope);
}
NodeContainers.Values.ForEach(b => b.AddReactiveNodeSwitch<TObservable>(trueConfigure, falseConfigure, instantiationScope));
return this;
Expand All @@ -129,7 +129,7 @@ public ILightTransitionPipelineConfigurator<TLight> AddPipelineSwitch<TObservabl
if (instantiationScope == InstantiationScope.Shared)
{
var observable = ActivatorUtilities.CreateInstance<TObservable>(serviceProvider);
return AddPipelineSwitch(observable, trueConfigure, falseConfigure);
return AddPipelineSwitch(observable, trueConfigure, falseConfigure, instantiationScope);
}
NodeContainers.Values.ForEach(b => b.AddPipelineSwitch<TObservable>(trueConfigure, falseConfigure, instantiationScope));
return this;
Expand Down
4 changes: 2 additions & 2 deletions ...ationPipelines.Lights/ReactiveNode/CompositeLightTransitionReactiveNodeConfigurator.On.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public ILightTransitionReactiveNodeConfigurator<TLight> On<T>(IObservable<T> tri
return this;
}

configurators.Values.ForEach(c => c.On(triggerObservable, pipelineConfigurator));
configurators.Values.ForEach(c => c.On(triggerObservable, pipelineConfigurator, instantiationScope));
return this;
}

Expand All @@ -67,7 +67,7 @@ public ILightTransitionReactiveNodeConfigurator<TLight> On<T>(IObservable<T> tri
return this;
}

configurators.Values.ForEach(c => c.On(triggerObservable, configure));
configurators.Values.ForEach(c => c.On(triggerObservable, configure, instantiationScope));
return this;
}

Expand Down