Added Terraform and Ansible code to automate the infra and configurations. #3
Conversation
…a and configurations
Feat: Added Terraform and Ansible configurations to automate the infr…
WalkthroughThe changes update the project’s documentation and deployment scripts by introducing Terraform and Ansible into the tech stack. The README now reflects new installation instructions for AWS CLI, Jenkins Master/Worker, and Bastion Host while updating the AWS region. Two new Ansible playbooks have been added—one for worker nodes and one for the master node—to automate the installation and configuration of tools such as Java, Docker, AWS CLI, and more. Additionally, new Terraform files provision the AWS infrastructure for an EKS cluster, and a local dependency has been added to the frontend. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Terraform
participant AWS
participant AnsibleMaster
participant AnsibleWorker
User->>Terraform: Run Terraform provisioning
Terraform->>AWS: Create VPC, subnets, security groups, and IAM roles
AWS-->>Terraform: Resources provisioned
Terraform->>AWS: Deploy EKS cluster and node group
AWS-->>Terraform: EKS cluster created
User->>AnsibleMaster: Execute master node playbook
AnsibleMaster->>AWS: Install Jenkins, Docker, AWS CLI, Kubectl, SonarQube, ArgoCD CLI
AWS-->>AnsibleMaster: Master node configured
User->>AnsibleWorker: Execute worker node playbook
AnsibleWorker->>AWS: Install Java, Docker, AWS CLI, Trivy, Kubectl
AWS-->>AnsibleWorker: Worker node configured
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (12)
ansible/agent_server_play.yml (1)
1-9: Clean Up YAML Formatting: Remove Trailing SpacesStatic analysis has flagged trailing spaces (e.g., around lines 5 and 9). Removing these trailing spaces will help achieve YAML linting compliance and improve file readability.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 5-5: trailing spaces
(trailing-spaces)
[error] 9-9: trailing spaces
(trailing-spaces)
ansible/master_server_play.yml (3)
1-5: Address Trailing Spaces in YAMLStatic analysis indicates trailing spaces on several lines (e.g., lines 1, 5, and others). Please remove these extra spaces to comply with YAML formatting guidelines.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1-1: trailing spaces
(trailing-spaces)
[error] 5-5: trailing spaces
(trailing-spaces)
113-115: Correct Typo in Completion MessageThe task name "Print Completetion Message" contains a typo. It should be "Print Completion Message" to avoid confusion.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 115-115: no new line character at the end of file
(new-line-at-end-of-file)
115-115: Ensure Newline at End of FileThe file is missing a newline at the end. Adding a newline helps maintain consistency and avoids potential linting issues.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 115-115: no new line character at the end of file
(new-line-at-end-of-file)
terraform/variables.tf (1)
61-61: Ensure Newline at End of FilePlease add a newline at the end of this file to adhere to common file formatting conventions.
terraform/main.tf (4)
5-7: Default Subnet Configuration (Availability Zone: ap-south-1a):
This subnet is properly set for the Mumbai region’s availability zone "ap-south-1a". For improved flexibility in the future, you might consider parameterizing the availability zone.
9-11: Default Subnet Configuration (Availability Zone: ap-south-1b):
The subnet for "ap-south-1b" is correctly defined. As with the previous subnet, consider using a variable for the availability zone to enhance reusability.
65-104: Worker Nodes Security Group Configuration:
The security group for EKS worker nodes includes similar open ingress rules (including SSH on port 22 and additional ports). Please review whether exposing these ports to "0.0.0.0/0" is intentional. Limiting broad access—especially for SSH—can enhance security.
171-201: EKS Node Group Configuration:
The node group resource is comprehensive—it specifies the cluster name, node role ARN, subnet IDs, scaling configuration, remote access setup, instance types, and tagging. A few minor suggestions:
- Consider parameterizing the scaling values (desired, max, min) for potential future adjustments.
- The use of interpolation in the instance_types list (
["${var.eks_node_instance_type}"]) can be simplified to[var.eks_node_instance_type]in newer Terraform versions.README.md (3)
47-56: Installation Table Formatting:
The installation table now includes new entries for Jenkins Master, Jenkins-Worker, Bastion-Host, Terraform, Ansible, and Jenkins Worker Setup. To meet markdownlint MD055 guidelines, please ensure that each table row ends with a trailing pipe ("|") for consistency.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
49-49: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe(MD055, table-pipe-style)
68-69: Region Specification Clarity:
The note indicates that the project will be implemented in the Mumbai region (ap-south-1). For clarity and conciseness, consider rephrasing to something like, "This project will be deployed in the Mumbai region (ap-south-1)."
70-72: Instance Usage Description:
The statement “This instance primary use is to launch the EKS cluster using Terraform” appears slightly awkward. Rewording to “The primary use of this instance is to launch the EKS cluster using Terraform” would enhance clarity. Additionally, verify that the sentence is complete as intended.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
Assets/ansible-master-installation.pngis excluded by!**/*.pngAssets/ansible-worker-installation.pngis excluded by!**/*.pngAssets/terraform-provisioning.pngis excluded by!**/*.pngfrontend/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (7)
README.md(5 hunks)ansible/agent_server_play.yml(1 hunks)ansible/master_server_play.yml(1 hunks)frontend/package.json(1 hunks)terraform/main.tf(1 hunks)terraform/providers.tf(1 hunks)terraform/variables.tf(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
ansible/agent_server_play.yml
[error] 5-5: trailing spaces
(trailing-spaces)
[error] 9-9: trailing spaces
(trailing-spaces)
[error] 19-19: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 49-49: trailing spaces
(trailing-spaces)
[error] 84-84: trailing spaces
(trailing-spaces)
[error] 99-99: no new line character at the end of file
(new-line-at-end-of-file)
ansible/master_server_play.yml
[error] 1-1: trailing spaces
(trailing-spaces)
[error] 5-5: trailing spaces
(trailing-spaces)
[error] 10-10: trailing spaces
(trailing-spaces)
[error] 62-62: trailing spaces
(trailing-spaces)
[error] 73-73: trailing spaces
(trailing-spaces)
[error] 101-101: trailing spaces
(trailing-spaces)
[error] 115-115: no new line character at the end of file
(new-line-at-end-of-file)
🪛 markdownlint-cli2 (0.17.2)
README.md
49-49: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
73-73: Multiple headings with the same content
null
(MD024, no-duplicate-heading)
158-158: Multiple spaces after blockquote symbol
null
(MD027, no-multiple-space-blockquote)
160-160: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
205-205: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
209-209: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
235-235: Multiple headings with the same content
null
(MD024, no-duplicate-heading)
🪛 LanguageTool
README.md
[grammar] ~185-~185: Uncountable nouns are usually not used with an indefinite article. Use simply “decent access”.
Context: ...ec2-key-pair.pem ``` > [!Note] > Give a decent access to the private key (.pem) file to run p...
(A_UNCOUNTABLE)
[grammar] ~213-~213: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ilable in your aws account. This will setup all the configuration on those 2 EC2 in...
(NOUN_VERB_CONFUSION)
🔇 Additional comments (16)
terraform/providers.tf (2)
1-6: AWS Provider Requirement ConfigurationThe
terraformblock correctly configures the AWS provider with a version constraint of "~> 5.0". Ensure that this version range is tested with your intended AWS features.
10-12: Configuring AWS Region Using a VariableThe provider block uses
region = var.aws_region, which follows best practices for configurability. Please confirm thataws_regionis defined (as done later interraform/variables.tf) and the default value aligns with your target deployment region.ansible/agent_server_play.yml (1)
1-99: Overall Agent Playbook ReviewThe playbook methodically updates the Apt cache and installs/configures key tools including Java 17, Docker, AWS CLI, Kubectl, and Trivy for the worker nodes. Ensure that all manual steps (such as AWS CLI configuration) are clearly documented for end users.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 5-5: trailing spaces
(trailing-spaces)
[error] 9-9: trailing spaces
(trailing-spaces)
[error] 19-19: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 49-49: trailing spaces
(trailing-spaces)
[error] 84-84: trailing spaces
(trailing-spaces)
[error] 99-99: no new line character at the end of file
(new-line-at-end-of-file)
ansible/master_server_play.yml (1)
1-115: Overall Master Server Playbook AssessmentThis playbook effectively orchestrates tasks for installing and configuring Jenkins, Docker, AWS CLI, Kubectl, SonarQube, and ArgoCD on the master node. Along with addressing minor formatting issues, ensure that the service configurations (e.g., for Jenkins and Docker) are verified in your staging environment.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1-1: trailing spaces
(trailing-spaces)
[error] 5-5: trailing spaces
(trailing-spaces)
[error] 10-10: trailing spaces
(trailing-spaces)
[error] 62-62: trailing spaces
(trailing-spaces)
[error] 73-73: trailing spaces
(trailing-spaces)
[error] 101-101: trailing spaces
(trailing-spaces)
[error] 115-115: no new line character at the end of file
(new-line-at-end-of-file)
terraform/variables.tf (1)
1-61: Terraform Variables Configuration ReviewAll variables are defined with clear descriptions and appropriate default values. This setup supports easy customization of AWS and EKS resources, aligning with modular infrastructure best practices. Verify that the default values (such as region and AMI ID) are updated as needed for your environment.
terraform/main.tf (8)
1-3: Default VPC Resource Declaration:
The declaration for the default VPC is minimal and straightforward. Ensure that this default VPC meets your needs, and consider adding further properties if additional configuration becomes necessary.
106-120: EKS Cluster IAM Role Configuration:
The IAM role for the EKS cluster is defined correctly with an appropriate assume-role policy. No further changes are needed here.
121-135: EKS Node IAM Role Configuration:
The IAM role for worker nodes has been appropriately set up with the EC2 service principal. Ensure that the permissions granted are in line with the principle of least privilege as your project evolves.
137-140: EKS Cluster Policy Attachment:
Attaching the cluster policy via a variable for the policy ARN is a flexible and sound approach.
142-154: EKS Cluster Resource Configuration:
The EKS cluster resource is well structured with its VPC configuration, linked subnets, and security group. Declaring an explicit dependency on the policy attachment helps ensure correct creation order.
156-159: EKS Worker Node Policy Attachment:
The worker node policy attachment is implemented correctly using a variable for the policy ARN.
161-164: EKS CNI Policy Attachment:
The attachment of the CNI policy for networking is clear and uses variables effectively.
166-169: EKS ECR Read-Only Policy Attachment:
The read-only ECR policy is attached appropriately to the worker node role.README.md (3)
27-28: Tech Stack Update:
The addition of "Terraform (Infrastructure Provisioning)" and "Ansible (Configuration Management)" to the tech stack list clearly reflects the new automation goals of the project. This inclusion aligns well with the PR objectives.
78-82: Jenkins Instance Specifications:
The instructions for creating the Jenkins Master and Jenkins Worker instances are descriptive and clear. Ensure that the provided hardware specifications (e.g., 2 CPU, 8GB RAM, 29 GB storage on t2.large instances) align with your production requirements.
87-89: Bastion Host Setup:
The Bastion Host instructions are now explicitly defined, indicating its dual purpose—for provisioning the EKS cluster with Terraform and configuring nodes with Ansible. Verify that any associated security group rules or key management practices are updated accordingly.
| "axios": "^1.6.1", | ||
| "class-variance-authority": "^0.7.0", | ||
| "clsx": "^2.0.0", | ||
| "frontend": "file:", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Verify Local Dependency Specification
The new dependency "frontend": "file:" appears to reference a local package, but the path is incomplete. Typically, a local dependency should specify a relative path (e.g., "file:../some-local-folder"). Please confirm that this is intentional and update the value if needed to ensure proper dependency resolution.
| resource "aws_security_group" "cluster_sg" { | ||
| name = "cluster-sg" | ||
| description = "Security group for meet application" | ||
| vpc_id = aws_default_vpc.default_vpc.id | ||
|
|
||
| ingress { | ||
| from_port = 22 | ||
| to_port = 22 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| ingress { | ||
| from_port = 80 | ||
| to_port = 80 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| ingress { | ||
| from_port = 443 | ||
| to_port = 443 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| ingress { | ||
| from_port = 10250 | ||
| to_port = 10250 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| ingress { | ||
| from_port = 30000 | ||
| to_port = 32767 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| egress { | ||
| from_port = 0 | ||
| to_port = 0 | ||
| protocol = "-1" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| tags = { | ||
| Name = "cluster_sg" | ||
| } | ||
| } |
There was a problem hiding this comment.
Cluster Security Group Configuration:
This security group defines multiple ingress rules covering SSH (port 22), HTTP (port 80), HTTPS (port 443), Kubernetes API (port 10250), and a NodePort range (30000–32767). A couple of points to consider:
- Allowing SSH access from "0.0.0.0/0" can pose a security risk. It is advisable to restrict this to known IP ranges if possible.
- The description ("Security group for meet application") might be refined to clearly reflect its purpose in managing access to the EKS cluster.
1 participant
Description:
This PR introduces Terraform and Ansible automation for provisioning infrastructure and configuring the environment.
Key Changes:
README.md) with deployment steps.How to Test:
terraform/directory and initialize Terraform:Checklist:
#Open to feedback and suggestions! 🚀
Summary by CodeRabbit
Documentation
New Features