Convert BPManagedCommand to a non-UObject#4
Open
slonopotamus wants to merge 1 commit intoDeviantdVeloper:developmentfrom
Open
Convert BPManagedCommand to a non-UObject#4slonopotamus wants to merge 1 commit intoDeviantdVeloper:developmentfrom
slonopotamus wants to merge 1 commit intoDeviantdVeloper:developmentfrom
Conversation
Rationale: there is no need to put pressure on GC Also, prevent crash in BPManagedCommand::UpdateDevice if curve was not specified
slonopotamus
force-pushed
the
non-uobject-managedcommand
branch
from
0bdbc31 to
2f52238
Compare
Owner
|
I like this conceptually, I always thought UObjects were a little heavy handed for this particular task but also well suited, and of course stopping crashes is a no brainer. I will look over this in more detail later and give it some testing too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: there is no need to put pressure on GC
Also, prevent crash in BPManagedCommand::UpdateDevice if curve was not specified