Replace if/elsif chain in UBPDeviceSubsystem::OnMessage with virtual method#5
Open
slonopotamus wants to merge 1 commit intoDeviantdVeloper:developmentfrom
Open
Conversation
slonopotamus
force-pushed
the
if-elsif-to-virtual
branch
from
af7c6c5 to
984db91
Compare
Owner
DeviantdVeloper
left a comment
DeviantdVeloper
left a comment
There was a problem hiding this comment.
This is significantly less cursed than my current implementation, and I imagine uses some feature of Instanced Structs I am not aware of.
I will test and check.
Author
|
I have more plans for code improvements (including solving TODO in current PR), but didn't want to pile up a massive change set, so trying to improve things gradually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.