Add toggle to enable/disable insecure settings#3722
Merged
Martí Climent (marticliment) merged 1 commit intomainfrom Jun 7, 2025
Merged
Add toggle to enable/disable insecure settings#3722Martí Climent (marticliment) merged 1 commit intomainfrom
Martí Climent (marticliment) merged 1 commit intomainfrom
Conversation
11 tasks
Contributor
|
Does this enable the implementation of #3038 as well? Or do you still have reservations about that? |
Collaborator
Author
|
Yeah, it does. However, I want to do a generic pre and post install steps, to allow for more things aside from custom commands (kill an app before updating, cleanup after update, etc.) |
Contributor
|
OK, I'll leave that one to you then, but I'm happy to help if you would like. |
Collaborator
Author
|
Wait this is not supposed to be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain features, such as custom command-line arguments, and future ones such as pre-install and post-install scripts, pose an important security risk. They should be disabled by default, and in a way that a remote, unauthorized agent cannot manually enable this features.