Skip to content

Add toggle to enable/disable insecure settings#3722

Merged
Martí Climent (marticliment) merged 1 commit intomainfrom
Add-secure-settings-toggle
Jun 7, 2025
Merged

Add toggle to enable/disable insecure settings#3722
Martí Climent (marticliment) merged 1 commit intomainfrom
Add-secure-settings-toggle

Conversation

@marticliment
Copy link
Collaborator

Certain features, such as custom command-line arguments, and future ones such as pre-install and post-install scripts, pose an important security risk. They should be disabled by default, and in a way that a remote, unauthorized agent cannot manually enable this features.

  • Implement secure settings (can only be changed with administrator permissions, yet they should be user-based)
  • Create a settings page to handle these secure settings. Create a UI warning to enable and disable them.

@mrixner
Copy link
Contributor

mrixner commented Jun 7, 2025

Does this enable the implementation of #3038 as well? Or do you still have reservations about that?

@marticliment
Copy link
Collaborator Author

Martí Climent (marticliment) commented Jun 7, 2025

Yeah, it does. However, I want to do a generic pre and post install steps, to allow for more things aside from custom commands (kill an app before updating, cleanup after update, etc.)

@mrixner
Copy link
Contributor

mrixner commented Jun 7, 2025

OK, I'll leave that one to you then, but I'm happy to help if you would like.

@marticliment Martí Climent (marticliment) merged commit a3bbdfa into main Jun 7, 2025
2 checks passed
@marticliment
Copy link
Collaborator Author

Wait this is not supposed to be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants