Add toggle to enable/disable insecure settings#3723
Merged
Martí Climent (marticliment) merged 12 commits intomainfrom Jun 13, 2025
Merged
Add toggle to enable/disable insecure settings#3723Martí Climent (marticliment) merged 12 commits intomainfrom
Martí Climent (marticliment) merged 12 commits intomainfrom
Conversation
11 tasks
…ureSettingsCheckbox
…climent/UniGetUI into Add-secure-settings-toggle
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a toggle for enabling/disabling insecure settings to reduce security risks. Key changes include updating UI text and controls for administrator-related settings, integrating new secure settings CLI commands, and refactoring installation option handling to work with secure settings.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/UniGetUI/Pages/SettingsPages/GeneralPages/Updates.xaml | Updated border and text for settings cards to reflect new secure settings messaging. |
| src/UniGetUI/Pages/SettingsPages/GeneralPages/SettingsHomepage.xaml(.cs) | Renamed and reordered settings buttons, and added a new shortcut for manager preferences. |
| src/UniGetUI/Pages/SettingsPages/GeneralPages/Operations.xaml | Updated text to match the revised administrator settings terminology. |
| src/UniGetUI/Pages/SettingsPages/GeneralPages/Experimental.xaml | Minor UI spacing adjustments with no functional change. |
| src/UniGetUI/Pages/SettingsPages/GeneralPages/Administrator.xaml(.cs) | Introduced a warning title bar and reworded texts to alert users about potential security risks. |
| src/UniGetUI/Pages/DialogPages/InstallOptions_Package.xaml.cs | Commented out a condition related to overriding settings – behavior change should be verified. |
| src/UniGetUI/EntryPoint.cs | Added new CLI argument branches to enable/disable secure settings. |
| src/UniGetUI/Controls/SettingsWidgets/{SecureCheckboxCard.cs, CheckboxCard.cs} | Added support for warning texts and inversion logic for secure settings toggles. |
| src/UniGetUI/CLIHandler.cs | Updated trimming logic for CLI arguments and added secure settings commands. |
| src/UniGetUI.PackageEngine.Serializable/InstallOptions.cs & InstallOptionsFactory.cs | Removed in-method sanitation and introduced secure options handling. |
| src/UniGetUI.Core.SecureSettings/* | New project to manage secure settings with elevated permissions. |
| cli-arguments.md | Updated documentation to reflect new CLI commands for secure settings. |
Comments suppressed due to low confidence (1)
src/UniGetUI/Pages/SettingsPages/GeneralPages/Administrator.xaml:77
- There is a spelling mistake in the warning text ('thay' should be 'they').
<widgets:TranslatedTextBlock Text="Pre and post install commands can do very nasty things to your device, if designed to do so. Be aware thay they may break things unless used carefully" />
| if (options.CustomParameters.Count > 0) | ||
| Logger.Warn($"Custom CLI parameters [{string.Join(' ', options.CustomParameters)}] will be discarded"); | ||
|
|
||
| options.CustomParameters = []; |
There was a problem hiding this comment.
The assignment 'options.CustomParameters = [];' may cause issues if CustomParameters is not of an array type; consider using an appropriate collection initializer (e.g., new List()) to match its declared type.
Comment on lines
+318
to
+321
| //if (!options.OverridesNextLevelOpts) | ||
| //{ | ||
| options = await InstallOptionsFactory.LoadApplicableAsync(this.Package, overridePackageOptions: options); | ||
| //} |
There was a problem hiding this comment.
Commenting out the condition that checks 'OverridesNextLevelOpts' changes the logic of updating options; please confirm that this behavioral change is intentional.
| CoreTools.Translate("Enable the settings below if and only if you fully understand what they do, and the implications they may have.") + "\n\n" + | ||
| CoreTools.Translate("The settings will list, in their descriptions, the potential security issues they may have.") + " "; | ||
|
|
||
| // The following settings may pose a security risk, hence they are disabled by default. Enable them ONLY if you undertsand what you are doing. Some of those settings will show a UAC prompt before being enabled." |
There was a problem hiding this comment.
There is a spelling mistake in the comment ('undertsand' should be 'understand').
Suggested change
| // The following settings may pose a security risk, hence they are disabled by default. Enable them ONLY if you undertsand what you are doing. Some of those settings will show a UAC prompt before being enabled." | |
| // The following settings may pose a security risk, hence they are disabled by default. Enable them ONLY if you understand what you are doing. Some of those settings will show a UAC prompt before being enabled." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain features, such as custom command-line arguments, and future ones such as pre-install and post-install scripts, pose an important security risk. They should be disabled by default, and in a way that a remote, unauthorized agent cannot manually enable this features.