Skip to content

Fix #4145 - Fixed self deadlock that hangs the application on icon fetch #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martí Climent (marticliment) merged 3 commits into from
Oct 30, 2025
Merged

Fix #4145 - Fixed self deadlock that hangs the application on icon fetch #4182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69b591e
Fixed self deadlock that hangs the application on icon fetch.
Taron-art Oct 15, 2025
cced996
Merge branch 'main' into fix/4145-Opening-shared-package-hangs-the-ap…
marticliment Oct 15, 2025
80710b4
Merge branch 'main' into fix/4145-Opening-shared-package-hangs-the-ap…
marticliment Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/UniGetUI.Core.Classes/TaskRecycler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
=> _removeFromCache(method.GetHashCode(), 0);

// ---------------------------------------------------------------------------------------------------------------

Check warning on line 95 in src/UniGetUI.Core.Classes/TaskRecycler.cs

View workflow job for this annotation

GitHub Actions / test-codebase 

Avoid multiple blank lines (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide2000)

/// <summary>
/// Handles running the task if no such task was found on cache, and returning the cached task if it was found.
Expand All @@ -108,7 +108,7 @@
{
// Race condition, an equivalent task got added from another thread between the TryGetValue and TryAdd,
// so we are going to restart the call to _runTaskAndWait in order for TryGetValue to return the new task again
await _runTaskAndWait_VOID(task, hash, cacheTimeSecsSecs);
await _runTaskAndWait_VOID(task, hash, cacheTimeSecsSecs).ConfigureAwait(false);
return;
}
else
Expand All @@ -118,7 +118,7 @@
}

// Wait for the task to finish
await task;
await task.ConfigureAwait(false);

// Schedule the task for removal after the cache time expires
_removeFromCache_VOID(hash, cacheTimeSecsSecs);
Expand All @@ -138,7 +138,7 @@
{
// Race condition, an equivalent task got added from another thread between the TryGetValue and TryAdd,
// so we are going to restart the call to _runTaskAndWait in order for TryGetValue to return the new task again
return await _runTaskAndWait(task, hash, cacheTimeSecsSecs);
return await _runTaskAndWait(task, hash, cacheTimeSecsSecs).ConfigureAwait(false);
}
else
{
Expand All @@ -147,7 +147,7 @@
}

// Wait for the task to finish
ReturnT result = await task;
ReturnT result = await task.ConfigureAwait(false);

// Schedule the task for removal after the cache time expires
_removeFromCache(hash, cacheTimeSecsSecs);
Expand Down
Loading