Fixed snitches not firing when pearled into #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlayerTeleportEvent is fired before the player is actually teleported. As a result of this the location of the player as far as the event is concerned is where they are before they teleport. So when the snitch entry is handled it will take that location & not where they move to. By using the getTo() method & a player location override we can trigger snitches for when the player teleports in or out of a snitch field.
|
Can one of the admins verify this patch? @ProgrammerDan @Maxopoly "ok to test" will build any commits made to this PR |
xFier
changed the title
|
Seems fine. Probably a better time investment to help with the new version though. |
Author
|
I'm still working on the new version when I can, but I saw this was a quick fix for 1.12 currently |
|
I'll prioritize reviewing this. Sorry for delay.
…On Wed, Oct 9, 2019 at 8:53 PM xFier ***@***.***> wrote:
I'm still working on the new version when I can, but I saw this was a
quick fix for 1.12 currently
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61?email_source=notifications&email_token=AADD5DWVFAQZOOI3BXN6CQTQNZ4IHA5CNFSM4I6Y3L3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAZ6NGI#issuecomment-540272281>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADD5DWGHGIZXG34EVRDW7TQNZ4IHANCNFSM4I6Y3L3A>
.
|
|
Does this need testing? @ProgrammerDan @Maxopoly |
|
Should be straight forward enough to not do so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayerTeleportEvent is fired before the player is actually teleported. As a result of this the location of the player as far as the event is concerned is where they are before they teleport. So when the snitch entry is handled it will take that location & not where they move to. By using the getTo() method & a player location override we can trigger snitches for when the player teleports in or out of a snitch field.