Skip to content

Suport camera group ids for batch rendering on RT backend#108

Merged
yuecideng merged 4 commits intomainfrom
yueci/add-camera-group-id
Feb 12, 2026
Merged

Suport camera group ids for batch rendering on RT backend#108
yuecideng merged 4 commits intomainfrom
yueci/add-camera-group-id

Conversation

@yuecideng
Copy link
Contributor

@yuecideng yuecideng commented Jan 31, 2026

Description

Support group id control for RT batch rendering, which makes it more flexible to start/stop camera render pipeline.

TODO:

  • This PR needs upgraded dexsim version.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

@yuecideng yuecideng added the rendering Things related to rendering (eg, performace, efficiency, bug) label Jan 31, 2026
@yuecideng yuecideng marked this pull request as draft January 31, 2026 15:26
Copilot AI review requested due to automatic review settings February 11, 2026 15:54
@yuecideng yuecideng marked this pull request as ready for review February 11, 2026 15:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for controlling which RT camera groups are rendered during batched environment observation collection, enabling more flexible start/stop of camera rendering pipelines.

Changes:

  • Extend SimulationManager.render_camera_group to accept explicit group_ids and route them to the DexSim world RT renderer.
  • Track camera group IDs in BaseEnv (and from the record manager camera) and use them for RT batched rendering before sensor fetch.
  • Add an RT-enabled embodied env test case and bump dexsim_engine to 0.3.10.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
embodichain/lab/sim/sim_manager.py Changes RT render API to accept camera group IDs and forwards them to DexSim.
embodichain/lab/sim/sensors/camera.py Exposes Camera.group_id for RT camera-group identification.
embodichain/lab/gym/envs/base_env.py Collects camera group IDs and uses them for RT batch rendering prior to sensor data fetch.
embodichain/lab/gym/envs/managers/record.py Registers the recording camera’s group ID with the environment to include it in batch rendering.
tests/gym/envs/test_embodied_env.py Adds a CPU RT test variant exercising the RT-enabled path.
pyproject.toml Bumps dexsim_engine version pin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yuecideng yuecideng merged commit 7199f94 into main Feb 12, 2026
5 checks passed
@yuecideng yuecideng deleted the yueci/add-camera-group-id branch February 12, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rendering Things related to rendering (eg, performace, efficiency, bug)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants