Suport camera group ids for batch rendering on RT backend#108
Merged
Suport camera group ids for batch rendering on RT backend#108
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for controlling which RT camera groups are rendered during batched environment observation collection, enabling more flexible start/stop of camera rendering pipelines.
Changes:
- Extend
SimulationManager.render_camera_groupto accept explicitgroup_idsand route them to the DexSim world RT renderer. - Track camera group IDs in
BaseEnv(and from the record manager camera) and use them for RT batched rendering before sensor fetch. - Add an RT-enabled embodied env test case and bump
dexsim_engineto0.3.10.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
embodichain/lab/sim/sim_manager.py |
Changes RT render API to accept camera group IDs and forwards them to DexSim. |
embodichain/lab/sim/sensors/camera.py |
Exposes Camera.group_id for RT camera-group identification. |
embodichain/lab/gym/envs/base_env.py |
Collects camera group IDs and uses them for RT batch rendering prior to sensor data fetch. |
embodichain/lab/gym/envs/managers/record.py |
Registers the recording camera’s group ID with the environment to include it in batch rendering. |
tests/gym/envs/test_embodied_env.py |
Adds a CPU RT test variant exercising the RT-enabled path. |
pyproject.toml |
Bumps dexsim_engine version pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support group id control for RT batch rendering, which makes it more flexible to start/stop camera render pipeline.
TODO:
dexsimversion.Type of change
Checklist
black .command to format the code base.