Fix [xyz, quat] format pose ik computation for robot#149
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the inverse kinematics (IK) computation when using the 7-element [x, y, z, w, x, y, z] pose format (position + quaternion). The original code incorrectly called quat_from_matrix() on quaternion values, which expects a 3x3 rotation matrix as input. The fix properly uses matrix_from_quat() to convert quaternions to rotation matrices before building the 4x4 homogeneous transformation matrix.
Changes:
- Fixed
compute_ikmethod to properly convert [xyz, quat] format poses to 4x4 matrices - Fixed
compute_batch_ikmethod with the same quaternion-to-matrix conversion logic - Added test coverage to verify IK produces identical results for both matrix and [xyz, quat] pose formats
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| embodichain/lab/sim/objects/robot.py | Fixed quaternion-to-matrix conversion in compute_ik and compute_batch_ik methods by replacing incorrect quat_from_matrix calls with correct matrix_from_quat calls, and importing the required function |
| tests/sim/solvers/test_opw_solver.py | Added test case to verify IK computation produces consistent results for both 4x4 matrix and 7-element [xyz, quat] pose formats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
black .command to format the code base.