Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new end-effector asset dataset entries to EmbodiChain’s Open3D-backed download dataset registry so users can resolve URDF paths via get_data_path().
Changes:
- Add
DH_AG95dataset entry pointing toDH_AG95.zip. - Add
Robotiqdataset entry bundlingrobotiq_arg2f_85androbotiq_arg2f_140underRobotiq.zip.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| dh_ag95.urdf | ||
|
|
||
| Example usage: | ||
| >>> from embodichain.data.eef_dataset import DH95 |
Comment on lines
+260
to
+262
| Example usage: | ||
| >>> from embodichain.data.eef_dataset import Robotiq | ||
| >>> dataset = Robotiq() |
Comment on lines
+139
to
+147
| def __init__(self, data_root: str = None): | ||
| data_descriptor = o3d.data.DataDescriptor( | ||
| os.path.join(EMBODICHAIN_DOWNLOAD_PREFIX, eef_assets, "DH_AG95.zip"), | ||
| "34b6f3c2f649697ea7f12814b6a50529", | ||
| ) | ||
| prefix = "DH_AG95" | ||
| path = EMBODICHAIN_DEFAULT_DATA_ROOT if data_root is None else data_root | ||
|
|
||
| super().__init__(prefix, data_descriptor, path) |
yuecideng
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add tools:
Type of change
Checklist
black .command to format the code base.