Conversation
mecha
left a comment
There was a problem hiding this comment.
Rather than having Factory and Extension implement ServiceInterface, why not have the Service base class implement the interface and remove the duplicate abstract __invoke method? That way we avoid any signature conflicts between the Service class and the interface.
Because it is abstract. I don't want to impose an interface on an abstract class.
Missed that, thanks! |
I don't understand. The purpose of the class is to reduce duplicate code between |
This implements
dhii/services-interface. Also, see container-interop/service-provider#53.