Flesh out support for Ethernet protocol variant #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused macro $(SYSTEM) and $(controller) Provide default for $(SPT). The example shows SPT==SPLY.
Start from digitelQpc.proto and do a direct replacement removing the prefix and suffix which the ethernet protocol doesn't include. Include '>' prompt in InTerminator, which works except for the very first reply, which includes the initial '>'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find that the existing digitelQpcEthernet.proto seems to be incomplete. I tried to fill it out, but had enough trouble that I wiped most of it and took digitelQpc.proto as a starting point. This mostly consisted of removing/replacing the differing prefix and suffix on all commands. So I think it is most meaningful to compare these two files.
So far I've only run this for a short while, and I haven't exercised many of the settings. The only issue I see is that the initial ">" prompt sent by the device isn't accounted for, so the first reply will mis-match. After that point all appears well.