Upgrade to ADCore R3-0 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlmuir
force-pushed
the
adcore-3
branch
2 times, most recently
from
3a69138 to
1523c32
Compare
Change the build files to use the ADCore R3-0 build files structure. Fix the plugin constructor arguments to the super constructor by removing numParams and adding maxThreads. (These ADCore changes were introduced in R3-0 in commit 3af87bd.) Fix the super call in processCallbacks to call NDPluginDriver's beginProcessCallbacks method since processCallbacks in NDPluginDriver was renamed to beginProcessCallbacks. (This ADCore change was introduced in R3-0 in commit 3af87bd.) Call start() in adPythonPluginConfigure, and rename the start variable in processCallbacks to startTime to avoid shadowing the start method. (The start method was added in ADCore in R2-5 in commit b1a2f13.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the plugin constructor arguments to the super constructor by
removing numParams and adding maxThreads. (These ADCore changes were
introduced in R3-0 in commit 3af87bd.)
Fix the super call in processCallbacks to call NDPluginDriver's
beginProcessCallbacks method since processCallbacks in NDPluginDriver
was renamed to beginProcessCallbacks. (This ADCore change was
introduced in R3-0 in commit 3af87bd.)
Call start() in adPythonPluginConfigure. (The start method was added in
ADCore in R2-5 in commit b1a2f13.)