Skip to content

Get beamline params from beamline files #1855

@jacob720

Description

@jacob720

Could: This is a bit of scope creep but the way we're doing this is a bit messy. I think we can do it like we do

def daq_configuration_path() -> str:
and load it in as part of the beamline file. If that makes sense? Can you either do here or make a new issue?

Originally posted by @DominicOram in #1773 (comment)

Currently, we have a get_beamline_parmeters() function in dodal/common/ that can be called to retrieve beamline parameters where needed. It would be cleaner to have a per-beamline function in ixx.py, and then beamline params can be passed in to devices when initialised.

There's still a question of how to get beamline parameters in common plans.

Acceptance Criteria

  • Each beamline file has a get_beamline_parameters function
  • Devices that require beamline parameters recieve them when initialised.
  • Common plans that require beamline parameters still work

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions