-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Could: This is a bit of scope creep but the way we're doing this is a bit messy. I think we can do it like we do
and load it in as part of the beamline file. If that makes sense? Can you either do here or make a new issue?dodal/src/dodal/beamlines/i03.py
Line 92 in d245f0a
def daq_configuration_path() -> str:
Originally posted by @DominicOram in #1773 (comment)
Currently, we have a get_beamline_parmeters() function in dodal/common/ that can be called to retrieve beamline parameters where needed. It would be cleaner to have a per-beamline function in ixx.py, and then beamline params can be passed in to devices when initialised.
There's still a question of how to get beamline parameters in common plans.
Acceptance Criteria
- Each beamline file has a
get_beamline_parametersfunction - Devices that require beamline parameters recieve them when initialised.
- Common plans that require beamline parameters still work
Metadata
Metadata
Assignees
Labels
No labels