-
Notifications
You must be signed in to change notification settings - Fork 12
Add glossary and style guide #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 289 289
Lines 11030 11060 +30
=======================================
+ Hits 10926 10956 +30
Misses 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 303 303
Lines 11446 11446
=======================================
Hits 11342 11342
Misses 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oliwenmandiamond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good and have no objections. Probably need a wider consensus than just myself though
Villtord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks it looks great!
I am not a native English speaker so please double check my suggestions :)
c6f90d8 to
31362d2
Compare
DominicOram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! I have added some suggestions but all optional
1453be2 to
d3b3263
Compare
90f6f68 to
610e597
Compare
d2d2207 to
77cf9bc
Compare
Adds a glossary of terms, and style guide.
Closes #876 and #1481.
Instructions to reviewer on how to test: