Skip to content

Conversation

@noemifrisina
Copy link
Collaborator

@noemifrisina noemifrisina commented Jan 27, 2026

Can't use channel 1 or 2 on the overlay, so update the channel for the pin tip centre holder

Part of i19-bluesky#116

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@noemifrisina noemifrisina requested a review from a team as a code owner January 27, 2026 15:52
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (98eb4b6) to head (45ebc4b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1869   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         299      299           
  Lines       11323    11323           
=======================================
  Hits        11219    11219           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants