Refactor darks/flats config class to more clearly represent the various use-cases #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousefmoazzam
force-pushed
the
imgda-650
branch
from
9ded9be to
d501782
Compare
yousefmoazzam
force-pushed
the
refactor-darks-flats-config-class
branch
from
df082e3 to
2ddbdaf
Compare
To represent ignoring darks/flats, any function previously taking a value of type `DarksFlatsFileConfig` should now take an `Optional[DarksFlatsFileConfig]`. Ie, the possibility of a `None` value replaces the `ignore` field. Note that not all affected functions have been updated in this change, to split up the change between the different layers of the software. Here, the layer at which `get_darks_flats()` is has been changed accordingly, but layers "further out from `get_darks_flats()`" (such as `parse_config()`) will be updated in a separate change.
yousefmoazzam
force-pushed
the
refactor-darks-flats-config-class
branch
from
2ddbdaf to
ae53d74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IMGDA-722
Depends on #683 being merged first.
Checklist