Skip to content

Conversation

@yousefmoazzam
Copy link
Collaborator

@yousefmoazzam yousefmoazzam commented Jan 22, 2025

Add tests for workflow queries where the workflow is in one of the following phases: "failed", "errored", "running", "null".

See the following github discussion regarding the "null" phase, as well as the enquiries we had to the argo workflow developers about getting a workflow in a "pending" phase: argoproj/argo-workflows#14119

@yousefmoazzam yousefmoazzam marked this pull request as ready for review January 23, 2025 09:30
@yousefmoazzam yousefmoazzam added the rust Pull request that updates Rust code label Jan 23, 2025
@yousefmoazzam yousefmoazzam marked this pull request as draft January 24, 2025 11:09
@yousefmoazzam yousefmoazzam force-pushed the add-workflow-status-tests branch from 9886011 to a8c6673 Compare January 24, 2025 11:29
@yousefmoazzam yousefmoazzam marked this pull request as ready for review January 27, 2025 15:02
@yousefmoazzam yousefmoazzam force-pushed the add-workflow-status-tests branch from a8c6673 to 7c66790 Compare January 27, 2025 15:29
Copy link
Contributor

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only suggestion is that test-resources might be better named test-assets

Copy link
Contributor

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yousefmoazzam yousefmoazzam merged commit e072dd9 into main Jan 27, 2025
30 checks passed
@yousefmoazzam yousefmoazzam deleted the add-workflow-status-tests branch January 27, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull request that updates Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants