Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 10, 2024

This PR fixes 4 functional tests.

To test this:

Compile:

./autogen.sh
./configure
make -j 8

Run Specific Functional Tests

python rpc_createmultisig.py --descriptors 
python rpc_createmultisig.py --legacy-wallet

Update

wallet_coinbase_category.py --descriptors
wallet_coinbase_category.py --legacy-wallet

JaredTate
JaredTate previously approved these changes Mar 11, 2024
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Compiles & runs good.
Screenshot 2024-03-11 at 10 02 40 AM

ycagel
ycagel previously approved these changes Mar 11, 2024
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks @Jongjan88!

@ghost ghost dismissed stale reviews from ycagel and JaredTate via f79ce55 March 11, 2024 22:54
@ghost ghost changed the title Fix 2 Functional Tests Fix 4 Functional Tests Mar 11, 2024
@ghost ghost requested review from JaredTate and ycagel March 11, 2024 22:55
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Compiles and runs good!
Screenshot 2024-03-11 at 5 42 08 PM

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks @Jongjan88!

@ycagel ycagel merged commit 3fd7c74 into DigiByte-Core:develop Mar 11, 2024
@ghost ghost deleted the minipr2 branch March 12, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants