fix: use PIPELINE_DIR for config and hooks.d paths in log.sh#35
Merged
fix: use PIPELINE_DIR for config and hooks.d paths in log.sh#35
Conversation
log.sh hardcoded config and hooks.d paths relative to PROJECT_DIR/.claude/remember/, which breaks marketplace installs where the plugin lives in ~/.claude/plugins/cache/ instead. Fix: use PIPELINE_DIR (set by resolve-paths.sh) with fallback to the old PROJECT_DIR-based path for backward compatibility with local installs. 4 new tests: source inspection for both paths, marketplace layout config resolution, hooks.d dispatch from plugin directory. Closes #19 Co-Authored-By: Max <noreply>
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log.shhardcoded config.json and hooks.d paths relative toPROJECT_DIR/.claude/remember/, which breaks marketplace installs where the plugin lives in~/.claude/plugins/cache/instead.The bug (issue #19)
In marketplace installs,
save-session.shcallslog.shwhich tries to read$PROJECT_DIR/.claude/remember/config.json— a path that doesn't exist. Config defaults are used silently, and hooks.d dispatch never finds any hooks.The fix
Two lines in
log.sh:Uses
PIPELINE_DIR(set byresolve-paths.sh) with fallback to the old path for backward compat with local installs.Tests
4 new tests in
TestMarketplacePathResolution: source inspection for both paths, marketplace layout config resolution, hooks.d dispatch from plugin directory.Closes #19. Full suite: 224 passed, 99% coverage.
Thank you @vince-finqub for the detailed issue report with exact line numbers and suggested fixes — the analysis was spot on.