Skip to content

Add extra mouse event handling#304

Merged
nicoburns merged 9 commits intoDioxusLabs:mainfrom
rhaskia:main
Dec 15, 2025
Merged

Add extra mouse event handling#304
nicoburns merged 9 commits intoDioxusLabs:mainfrom
rhaskia:main

Conversation

@rhaskia
Copy link
Copy Markdown
Contributor

@rhaskia rhaskia commented Dec 14, 2025 •
edited by nicoburns
Loading

The following events now work with attributes:

  • oncontextmenu (no actual context menu support)
  • ondblclick
  • onmouseover
  • onmouseout
  • onmouseleave
  • onmouseenter
  • onscroll
  • onwheel

I did move the actual scroll handling code into handle_scroll, but it means redraw happens on every wheel event now, which is not ideal.

nicoburns
nicoburns requested changes Dec 14, 2025
View reviewed changes
Comment thread packages/blitz-dom/src/events/mouse.rs
Comment thread packages/blitz-dom/src/events/driver.rs
Comment thread packages/blitz-shell/src/window.rs Outdated
@rhaskia
Copy link
Copy Markdown
Contributor Author

rhaskia commented Dec 15, 2025

Fixed those issues with this newest commit, although the Instant is still where it was initially

nicoburns
nicoburns requested changes Dec 15, 2025
View reviewed changes
Comment thread packages/blitz-dom/src/events/driver.rs Outdated
Comment thread packages/blitz-dom/src/events/driver.rs Outdated
Comment thread packages/blitz-dom/src/events/driver.rs Outdated
Comment thread packages/blitz-dom/src/events/driver.rs Outdated
Comment thread packages/blitz-dom/src/events/driver.rs Outdated
nicoburns
nicoburns reviewed Dec 15, 2025
View reviewed changes
Comment thread packages/blitz-dom/src/document.rs Outdated
nicoburns
nicoburns reviewed Dec 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comments on a couple of important-but-trivial nits. And clippy/rustfmt need to be fixed. Other than that this it looking pretty close now?

@rhaskia
Copy link
Copy Markdown
Contributor Author

rhaskia commented Dec 15, 2025

Okay I'm not too sure why running cargo clippy on my machine didn't show that issue

@nicoburns
Copy link
Copy Markdown
Member

nicoburns commented Dec 15, 2025

Okay I'm not too sure why running cargo clippy on my machine didn't show that issue

You may need to run cargo clippy --workspace (aliased as just clippy if you have just installed) rather than just cargo clippy

@nicoburns
Copy link
Copy Markdown
Member

nicoburns commented Dec 15, 2025

Is there anything else you're still planning to do with this PR (it's still marked as a draft)?

The only thing I'm currently tracking is the extra request_redraw here: https://github.com/DioxusLabs/blitz/pull/304/changes#diff-d876680524cf67ed80f5091cadf5decf8ce9eef1842b8d827fc9c849ff1d037fR404

@rhaskia
Copy link
Copy Markdown
Contributor Author

rhaskia commented Dec 15, 2025

Yeah nothing else, I must have missed that extra redraw. I'll remove it and change the PR from draft.

@rhaskia rhaskia marked this pull request as ready for review December 15, 2025 21:41
@nicoburns nicoburns merged commit 9060de0 into DioxusLabs:main Dec 15, 2025
12 checks passed
@johnny-smitherson johnny-smitherson mentioned this pull request Feb 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoburns nicoburns nicoburns requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhaskia @nicoburns