Fix panic in resolve_stylist when animation entry is stale#408
Open
yes1688 wants to merge 1 commit intoDioxusLabs:mainfrom
Open
Fix panic in resolve_stylist when animation entry is stale#408yes1688 wants to merge 1 commit intoDioxusLabs:mainfrom
yes1688 wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
When `traverse_dom` writes node_ids into `animations.sets` during the first resolve, a subsequent removal of the animated node can leave a stale Slab key. The next resolve panics with "invalid key" on direct `self.nodes[node_id]` indexing. Fix: use `get_mut` and skip stale entries with `continue`. Repro: see DioxusLabs#407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #407 — panic with
"invalid key"inresolve_stylistwhen an animationentry's Slab key is stale after node removal.
Change
1-line fix using
get_mutto skip stale entries safely:Verification
resolve_stylist: "invalid key" when animation node tracked but removed #407 panics onmain(verified locally)packages/blitz-html/tests/html_document_test.rsNotes
If you'd prefer a different approach (e.g. cleaning up
animations.setson noderemoval at the source), happy to rework — just let me know your preference.
Drafted with Claude, fix and reproduction hand-verified.