feat(browser): Dioxus Tabs#412
Merged
nicoburns merged 1 commit intoDioxusLabs:mainfrom May 1, 2026
Merged
Conversation
Replace inline about:newtab HTML with a Dioxus-rendered AboutPage component, and extract URL/nav helpers from toolbar.rs into a new nav module. Settings, History, and Bookmarks are wired through the menu to Dioxus tabs and currently open a stub placeholder. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nicoburns
approved these changes
May 1, 2026
Member
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
I've noted a few quibbles in comments, but overall this looks good :)
Comment on lines
+156
to
+158
| if let Some(page) = about() { | ||
| *tab.title().write_unchecked() = page.title().to_string(); | ||
| } |
Member
There was a problem hiding this comment.
This could probably go directly in the use_memo above. But this is also fine.
| web-view { | ||
| key: "{id}", | ||
| class: "tab-content", | ||
| style: visibility, |
Member
There was a problem hiding this comment.
Note that you can do display: "block" instead of style: "display: block" if you want to.
| } | ||
|
|
||
| impl AboutPage { | ||
| pub fn from_url(url: &Url) -> Option<Self> { |
Member
There was a problem hiding this comment.
Nit: try_from_url would probably be a more idiomatic name as this is fallible and returns option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
about:newtabHTML with a Dioxus-renderedAboutPagecomponent.toolbar.rsinto a newnavmodule.Stubs
Settings,History, andBookmarksare wired through the menu toDioxus tabs and currently open a stub placeholder.