feat(browser): urlbar autocomplete and on-disk history#415
Merged
nicoburns merged 5 commits intoDioxusLabs:mainfrom May 4, 2026
Merged
feat(browser): urlbar autocomplete and on-disk history#415nicoburns merged 5 commits intoDioxusLabs:mainfrom
nicoburns merged 5 commits intoDioxusLabs:mainfrom
Conversation
Adds urlbar autocomplete (history matches + a "Search with DuckDuckGo" row, keyboard-driven) backed by a new sqlite history store that hydrates the in-memory BrowsingHistory on startup. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
# Conflicts: # apps/browser/src/browser_history.rs # apps/browser/src/tab.rs
tonybierman
force-pushed
the
rich-address-bar
branch
from
38da42c to
8d95ffd
Compare
nicoburns
reviewed
May 4, 2026
Member
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
A few suggestions. Nothing blocking, but a few that would clean up the code. Action any that you want to, and leave any that you don't and then ping me for re-review?
…ggestions - Move HistoryStore into a new workspace crate apps/browser/persistence, managed via rusqlite_migration. Introduce HistoryService that owns the in-memory Store and on-disk HistoryStore together so callers no longer write to both sides. - Replace urlbar substring matching with nucleo fuzzy ranking; add a Literal "what Enter would do" row; drop hover-to-select. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
The Android failure is not a code issue — it's a transient CI infrastructure failure. |
Contributor
Author
|
@nicoburns ready for re-review. significant changes. |
nicoburns
approved these changes
May 4, 2026
Member
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
I think we'd be a lot better off using the nucleo crate rather than nucleo-matcher. It does the hard part of computing suggestions in a background thread for us. And even has an API that allows us to retrieve results incrementally as they're computed. But this is fine for now :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds urlbar autocomplete (history matches + a "Search with DuckDuckGo" row, keyboard-driven) backed by a new sqlite history store that hydrates the in-memory
BrowsingHistoryon startup.